From 9944e94702140a8ab628b58c8a6ddee1fd419773 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 2 Oct 2026 22:29:54 +0000 Subject: [PATCH] test: migrate `stats/base/dists/chi/skewness` to ULP-based assertions Replace the computed relative-tolerance comparisons in `test/test.js` and `test/test.native.js` with `isAlmostSameValue` assertions. The ULP bound of `12890` is the measured minimum over the full fixture set for both the JavaScript and C implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_016FowxTcTEq1WLD4Vqu5hFD --- .../stats/base/dists/chi/skewness/test/test.js | 12 ++---------- .../base/dists/chi/skewness/test/test.native.js | 12 ++---------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.js index d0de850de6ef..6eef66f4664c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var skewness = require( './../lib' ); @@ -63,8 +63,6 @@ tape( 'if provided a degrees of freedom parameter `k` that is not a positive num tape( 'the function returns the skewness of a chi distribution', function test( t ) { var expected; - var delta; - var tol; var k; var i; var y; @@ -73,13 +71,7 @@ tape( 'the function returns the skewness of a chi distribution', function test( k = data.k; for ( i = 0; i < expected.length; i++ ) { y = skewness( k[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k:'+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1e-11 * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12890 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.native.js index 2e2abe0e9b32..929de2075707 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chi/skewness/test/test.native.js @@ -22,9 +22,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); // FIXTURES // @@ -68,8 +68,6 @@ tape( 'if provided a non-positive `k`, the function returns `NaN`', opts, functi tape( 'the function returns the skewness of a chi distribution', opts, function test( t ) { var expected; - var delta; - var tol; var k; var i; var y; @@ -78,13 +76,7 @@ tape( 'the function returns the skewness of a chi distribution', opts, function k = data.k; for ( i = 0; i < expected.length; i++ ) { y = skewness( k[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k:'+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1e-11 * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12890 ), true, 'returns expected value' ); } t.end(); });