From ccdc7e460caa9da8d02fb8bcd6107d08af2fec2f Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 2 Oct 2026 09:15:06 +0000 Subject: [PATCH 1/2] test: migrate `stats/base/dists/exponential/variance` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_019cxwB8hsgfXQPSnxV1q7n8 --- .../base/dists/exponential/variance/test/test.js | 14 +++----------- .../dists/exponential/variance/test/test.native.js | 14 +++----------- 2 files changed, 6 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js index de05f8cdea6d..f01b6bb3df40 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js @@ -21,10 +21,9 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var variance = require( './../lib' ); @@ -61,9 +60,8 @@ tape( 'if provided a rate parameter `lambda` that is not a nonnegative number, t tape( 'the function returns the variance of an exponential distribution', function test( t ) { var expected; + var MAX_ULP = 2; var lambda; - var delta; - var tol; var i; var y; @@ -71,13 +69,7 @@ tape( 'the function returns the variance of an exponential distribution', functi lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = variance( lambda[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[i], 'lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], MAX_ULP ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js index da434c202f6b..e08bf214d06e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js @@ -23,10 +23,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -70,9 +69,8 @@ tape( 'if provided a rate parameter `lambda` that is not a nonnegative number, t tape( 'the function returns the variance of an exponential distribution', opts, function test( t ) { var expected; + var MAX_ULP = 2; var lambda; - var delta; - var tol; var i; var y; @@ -80,13 +78,7 @@ tape( 'the function returns the variance of an exponential distribution', opts, lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = variance( lambda[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[i], 'lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], MAX_ULP ), true, 'returns expected value' ); } t.end(); }); From 380a371f8e8dfc4187cae8d82ec43b749d432143 Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 2 Oct 2026 04:25:45 -0700 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/dists/exponential/variance/test/test.js | 3 +-- .../stats/base/dists/exponential/variance/test/test.native.js | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js index f01b6bb3df40..3bda6ef2185d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.js @@ -60,7 +60,6 @@ tape( 'if provided a rate parameter `lambda` that is not a nonnegative number, t tape( 'the function returns the variance of an exponential distribution', function test( t ) { var expected; - var MAX_ULP = 2; var lambda; var i; var y; @@ -69,7 +68,7 @@ tape( 'the function returns the variance of an exponential distribution', functi lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = variance( lambda[i] ); - t.strictEqual( isAlmostSameValue( y, expected[ i ], MAX_ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js index e08bf214d06e..fa9a33ddf51c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/exponential/variance/test/test.native.js @@ -69,7 +69,6 @@ tape( 'if provided a rate parameter `lambda` that is not a nonnegative number, t tape( 'the function returns the variance of an exponential distribution', opts, function test( t ) { var expected; - var MAX_ULP = 2; var lambda; var i; var y; @@ -78,7 +77,7 @@ tape( 'the function returns the variance of an exponential distribution', opts, lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = variance( lambda[i] ); - t.strictEqual( isAlmostSameValue( y, expected[ i ], MAX_ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });