From c8d271e8a9e95f05f9c1bc15210db705bcc4463d Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 1 Oct 2026 18:25:31 +0000 Subject: [PATCH] test: migrate `stats/base/dists/erlang/quantile` to ULP-based assertions Replace the computed `delta`/`tol` comparisons in the fixture loops of `test/test.quantile.js` and `test/test.factory.js` with `isAlmostSameValue` assertions using the measured minimum ULP bound of 7. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012bYe5QJPN9wJxUADzW1a6S --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../erlang/quantile/test/test.factory.js | 33 +++---------------- .../erlang/quantile/test/test.quantile.js | 33 +++---------------- 2 files changed, 8 insertions(+), 58 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.factory.js index b71a0ca3e0de..d8c0451a2332 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -157,8 +156,6 @@ tape( 'the created function evaluates the quantile for `p` given large `k` and ` var expected; var quantile; var lambda; - var delta; - var tol; var p; var k; var y; @@ -171,13 +168,7 @@ tape( 'the created function evaluates the quantile for `p` given large `k` and ` for ( i = 0; i < p.length; i++ ) { quantile = factory( k[i], lambda[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', k:'+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 7 ), true, 'returns expected value' ); } t.end(); }); @@ -186,8 +177,6 @@ tape( 'the created function evaluates the quantile for `p` given large shape par var expected; var quantile; var lambda; - var delta; - var tol; var p; var k; var y; @@ -200,13 +189,7 @@ tape( 'the created function evaluates the quantile for `p` given large shape par for ( i = 0; i < p.length; i++ ) { quantile = factory( k[i], lambda[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', k:'+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 7 ), true, 'returns expected value' ); } t.end(); }); @@ -215,8 +198,6 @@ tape( 'the created function evaluates the quantile for `p` given large rate para var expected; var quantile; var lambda; - var delta; - var tol; var p; var k; var y; @@ -229,13 +210,7 @@ tape( 'the created function evaluates the quantile for `p` given large rate para for ( i = 0; i < p.length; i++ ) { quantile = factory( k[i], lambda[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', k:'+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 7 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.quantile.js b/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.quantile.js index 491dbc00b324..54d3b5f0b17e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.quantile.js +++ b/lib/node_modules/@stdlib/stats/base/dists/erlang/quantile/test/test.quantile.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var quantile = require( './../lib' ); @@ -119,8 +118,6 @@ tape( 'if provided a negative `lambda`, the function returns `NaN`', function te tape( 'the function evaluates the quantile for `x` given large parameters `k` and `lambda`', function test( t ) { var expected; var lambda; - var delta; - var tol; var p; var y; var i; @@ -132,13 +129,7 @@ tape( 'the function evaluates the quantile for `x` given large parameters `k` an lambda = bothLarge.lambda; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', k:'+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 7 ), true, 'returns expected value' ); } t.end(); }); @@ -146,8 +137,6 @@ tape( 'the function evaluates the quantile for `x` given large parameters `k` an tape( 'the function evaluates the quantile for `x` given large shape parameter `k`', function test( t ) { var expected; var lambda; - var delta; - var tol; var p; var y; var i; @@ -159,13 +148,7 @@ tape( 'the function evaluates the quantile for `x` given large shape parameter ` lambda = largeShape.lambda; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', k:'+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 7 ), true, 'returns expected value' ); } t.end(); }); @@ -173,8 +156,6 @@ tape( 'the function evaluates the quantile for `x` given large shape parameter ` tape( 'the function evaluates the quantile for `x` given large rate parameter `lambda`', function test( t ) { var expected; var lambda; - var delta; - var tol; var p; var y; var i; @@ -186,13 +167,7 @@ tape( 'the function evaluates the quantile for `x` given large rate parameter `l lambda = largeRate.lambda; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', k:'+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 7 ), true, 'returns expected value' ); } t.end(); });