From 622a308eec23e0686d6f4c183916f9cc5831fa8f Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 30 Sep 2026 18:28:38 +0000 Subject: [PATCH] test: migrate `stats/base/dists/hypergeometric/cdf` to ULP-based assertions Replace the relative tolerance assertions in the fixture loops of `test/test.cdf.js`, `test/test.factory.js`, and `test/test.native.js` with `isAlmostSameValue` ULP comparisons. The bound was measured empirically by bisecting the per-fixture ULP difference over the full 1000-point Julia fixture set; the maximum is 4240 ULP for the JavaScript and the C implementation alike, so 4240 is the minimum admissible bound. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01BFKMkGyXoycqdWUYnci3AS --- .../base/dists/hypergeometric/cdf/test/test.cdf.js | 13 ++----------- .../dists/hypergeometric/cdf/test/test.factory.js | 13 ++----------- .../dists/hypergeometric/cdf/test/test.native.js | 13 ++----------- 3 files changed, 6 insertions(+), 33 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.cdf.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.cdf.js index de35b27d57fd..a633a199513b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.cdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.cdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var cdf = require( './../lib' ); @@ -148,8 +147,6 @@ tape( 'if provided an `n` which is not a nonnegative integer, the function retur tape( 'the function evaluates the cdf for `x`', function test( t ) { var expected; - var delta; - var tol; var x; var N; var K; @@ -164,13 +161,7 @@ tape( 'the function evaluates the cdf for `x`', function test( t ) { n = data.n; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], N[i], K[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2150.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 4240 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.factory.js index 094dd633abd5..4f073947f52c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -220,9 +219,7 @@ tape( 'if provided an `n` which is not a nonnegative integer, the created functi tape( 'the created function evaluates the cdf for `x`', function test( t ) { var expected; - var delta; var cdf; - var tol; var i; var N; var K; @@ -238,13 +235,7 @@ tape( 'the created function evaluates the cdf for `x`', function test( t ) { for ( i = 0; i < x.length; i++ ) { cdf = factory( N[i], K[i], n[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2150.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 4240 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.native.js index ece41fba2a9d..2a7d4daf8db3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/cdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -124,8 +123,6 @@ tape( 'if provided an `n` which is not a nonnegative integer, the function retur tape( 'the function evaluates the cdf for `x`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var N; var K; @@ -140,13 +137,7 @@ tape( 'the function evaluates the cdf for `x`', opts, function test( t ) { n = data.n; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], N[i], K[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2150.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 4240 ), true, 'returns expected value' ); } t.end(); });