From 734e21d7cc663ae0eb39764b8875d1599c2d9704 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 29 Sep 2026 15:39:40 +0000 Subject: [PATCH] test: migrate `stats/base/dists/beta/logpdf` to ULP-based assertions Replaces the relative-tolerance comparisons (`delta <= tol`) in the fixture loops with `@stdlib/assert/is-almost-same-value` assertions. The ULP bounds are the measured minima over the full fixture sets: `45056` for the both-large fixtures, `20480` for the large `alpha` fixtures, and `13312` for the large `beta` fixtures. The same bounds hold for the JavaScript and native implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_018Jh65nerjkdreo4WZ75TVj --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../dists/beta/logpdf/test/test.factory.js | 33 +++---------------- .../dists/beta/logpdf/test/test.logpdf.js | 33 +++---------------- .../dists/beta/logpdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.factory.js index 67bfba14116b..ac0413df8e2f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.factory.js @@ -22,11 +22,10 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var ln = require( '@stdlib/math/base/special/ln' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -211,10 +210,8 @@ tape( 'if provided `beta < 1`, the created function returns `+Infinity` for `x` tape( 'the created function evaluates the logpdf for `x` given large `alpha` and `beta`', function test( t ) { var expected; var logpdf; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -226,13 +223,7 @@ tape( 'the created function evaluates the logpdf for `x` given large `alpha` and for ( i = 0; i < x.length; i++ ) { logpdf = factory( alpha[i], beta[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 45000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 45056 ), true, 'returns expected value' ); } t.end(); }); @@ -240,10 +231,8 @@ tape( 'the created function evaluates the logpdf for `x` given large `alpha` and tape( 'the created function evaluates the logpdf for `x` given a large `alpha`', function test( t ) { var expected; var logpdf; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -255,13 +244,7 @@ tape( 'the created function evaluates the logpdf for `x` given a large `alpha`', for ( i = 0; i < x.length; i++ ) { logpdf = factory( alpha[i], beta[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 20480 ), true, 'returns expected value' ); } t.end(); }); @@ -269,10 +252,8 @@ tape( 'the created function evaluates the logpdf for `x` given a large `alpha`', tape( 'the created function evaluates the logpdf for `x` given a large `beta`', function test( t ) { var expected; var logpdf; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -284,13 +265,7 @@ tape( 'the created function evaluates the logpdf for `x` given a large `beta`', for ( i = 0; i < x.length; i++ ) { logpdf = factory( alpha[i], beta[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 13312 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.logpdf.js b/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.logpdf.js index 71d6ff9182a5..4a6c7ae30dbd 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.logpdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.logpdf.js @@ -22,11 +22,10 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var ln = require( '@stdlib/math/base/special/ln' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logpdf = require( './../lib' ); @@ -163,10 +162,8 @@ tape( 'if provided `beta < 1`, the created function returns `+Infinity` for `x` tape( 'the function evaluates the logpdf for `x` given large `alpha` and `beta`', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var x; var y; @@ -177,23 +174,15 @@ tape( 'the function evaluates the logpdf for `x` given large `alpha` and `beta`' beta = bothLarge.beta; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 45000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 45056 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given large `alpha`', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var x; var y; @@ -204,23 +193,15 @@ tape( 'the function evaluates the logpdf for `x` given large `alpha`', function beta = largeAlpha.beta; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 20480 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given large `beta`', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var x; var y; @@ -231,13 +212,7 @@ tape( 'the function evaluates the logpdf for `x` given large `beta`', function t beta = largeBeta.beta; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 13312 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.native.js index 7274b25895af..0f9e667e0a70 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/logpdf/test/test.native.js @@ -24,11 +24,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var ln = require( '@stdlib/math/base/special/ln' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -172,10 +171,8 @@ tape( 'if provided `beta < 1`, the created function returns `+Infinity` for `x` tape( 'the function evaluates the logpdf for `x` given large `alpha` and `beta`', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var x; var y; @@ -186,23 +183,15 @@ tape( 'the function evaluates the logpdf for `x` given large `alpha` and `beta`' beta = bothLarge.beta; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 45000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 45056 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given large `alpha`', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var x; var y; @@ -213,23 +202,15 @@ tape( 'the function evaluates the logpdf for `x` given large `alpha`', opts, fun beta = largeAlpha.beta; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 22000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 20480 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given large `beta`', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var x; var y; @@ -240,13 +221,7 @@ tape( 'the function evaluates the logpdf for `x` given large `beta`', opts, func beta = largeBeta.beta; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 13312 ), true, 'returns expected value' ); } t.end(); });