From 3c1889055d354b54562758330b51a9ba878d2837 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 22:28:37 +0000 Subject: [PATCH] test: migrate `stats/base/dists/frechet/quantile` to ULP-based assertions Replace relative tolerance comparisons in the Julia fixture loops with `isAlmostSameValue` ULP difference assertions. The JavaScript and C implementations both return bit-identical values to the fixtures across all three fixture sets, so the measured minimum ULP bound is 0. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01EfjwehoSMdN3GyYaYExW7M --- .../frechet/quantile/test/test.factory.js | 33 +++---------------- .../frechet/quantile/test/test.native.js | 33 +++---------------- .../frechet/quantile/test/test.quantile.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.factory.js index 7e05a1a7f554..b3494a05b7c6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.factory.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -129,8 +128,6 @@ tape( 'the created function evaluates the quantile function for `p` given large var quantile; var expected; var alpha; - var delta; - var tol; var s; var p; var y; @@ -143,13 +140,7 @@ tape( 'the created function evaluates the quantile function for `p` given large for ( i = 0; i < p.length; i++ ) { quantile = factory( alpha[i], s[i], 0.0 ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. m: 0. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -158,8 +149,6 @@ tape( 'the created function evaluates the quantile function for `p` given large var quantile; var expected; var alpha; - var delta; - var tol; var s; var p; var y; @@ -172,13 +161,7 @@ tape( 'the created function evaluates the quantile function for `p` given large for ( i = 0; i < p.length; i++ ) { quantile = factory( alpha[i], s[i], 0.0 ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -187,8 +170,6 @@ tape( 'the created function evaluates the quantile function for `p` given large var quantile; var expected; var alpha; - var delta; - var tol; var s; var p; var y; @@ -201,13 +182,7 @@ tape( 'the created function evaluates the quantile function for `p` given large for ( i = 0; i < p.length; i++ ) { quantile = factory( alpha[i], s[i], 0.0 ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.native.js index df0fc3460da1..e2de8dbef9a2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -134,8 +133,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', opts, functio tape( 'the function evaluates the quantile for `p` given large `alpha`', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var p; var s; var y; @@ -147,13 +144,7 @@ tape( 'the function evaluates the quantile for `p` given large `alpha`', opts, f s = largeShape.s; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 300.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -161,8 +152,6 @@ tape( 'the function evaluates the quantile for `p` given large `alpha`', opts, f tape( 'the function evaluates the quantile for `p` given large `s`', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var p; var s; var y; @@ -174,13 +163,7 @@ tape( 'the function evaluates the quantile for `p` given large `s`', opts, funct s = largeScale.s; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1500.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -188,8 +171,6 @@ tape( 'the function evaluates the quantile for `p` given large `s`', opts, funct tape( 'the function evaluates the quantile for `p` given large `alpha` and `s`', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var p; var s; var y; @@ -201,13 +182,7 @@ tape( 'the function evaluates the quantile for `p` given large `alpha` and `s`', s = bothLarge.s; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 4100.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.quantile.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.quantile.js index 00f2e5ca5734..94d304a33ca7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.quantile.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/quantile/test/test.quantile.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var quantile = require( './../lib' ); @@ -121,8 +120,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', function test tape( 'the function evaluates the quantile function for `p` given large `alpha`', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var p; var y; @@ -134,13 +131,7 @@ tape( 'the function evaluates the quantile function for `p` given large `alpha`' s = largeShape.s; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -148,8 +139,6 @@ tape( 'the function evaluates the quantile function for `p` given large `alpha`' tape( 'the function evaluates the quantile function for `p` given large `s`', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var p; var y; @@ -161,13 +150,7 @@ tape( 'the function evaluates the quantile function for `p` given large `s`', fu s = largeScale.s; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -175,8 +158,6 @@ tape( 'the function evaluates the quantile function for `p` given large `s`', fu tape( 'the function evaluates the quantile function for `p` given large `alpha` and `s`', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var p; var y; @@ -188,13 +169,7 @@ tape( 'the function evaluates the quantile function for `p` given large `alpha` s = bothLarge.s; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha: '+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. m: 0. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });