From 884ba640c4c889b57f437ee6d4748a1d62890ef6 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 21:18:18 +0000 Subject: [PATCH 1/3] test: migrate `math/base/tools/continued-fraction` to ULP-based assertions Resolves a part of #11352 Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01FCnzQTGQcf2Uwq55pfH2oF --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: skipped - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../test/es2015-generator/index.js | 8 ++++---- .../base/tools/continued-fraction/test/test.js | 15 +++++++-------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js index 0fb045537783..1efde7819426 100644 --- a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js +++ b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js @@ -23,7 +23,7 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var continuedFraction = require( './../../lib/' ); @@ -34,7 +34,7 @@ tape( 'if provided a generator function, the function evaluates the correspondin var expected = 0.5819767068693261; var actual = continuedFraction( generator() ); - t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' ); t.end(); function* generator() { @@ -52,14 +52,14 @@ tape( 'if provided a generator function, the function evaluates the correspondin 'keep': true }); - t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' ); actual = continuedFraction( generator2(), { 'keep': true }); expected = 1.525135276160983; - t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 13 ), true, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/test.js b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/test.js index e97881cdef8d..c4c4044a0de6 100644 --- a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/test.js +++ b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/test.js @@ -23,8 +23,7 @@ var tape = require( 'tape' ); var proxyquire = require( 'proxyquire' ); var detectGeneratorSupport = require( '@stdlib/assert/has-generator-support' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var continuedFraction = require( './../lib' ); var continuedFractionBasic = proxyquire( './../lib', { 'detect-generator-support': function getFalse() { return false; } @@ -55,7 +54,7 @@ tape( 'by default, the function evaluates the continued fraction without the lea var expected = 0.5819767068693261; var actual = continuedFraction( generator() ); - t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' ); t.end(); function generator() { @@ -74,7 +73,7 @@ tape( 'by default, the function evaluates the continued fraction without the lea var expected = 0.5819767068693261; var actual = continuedFractionBasic( generator() ); - t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' ); t.end(); function generator() { @@ -94,14 +93,14 @@ tape( 'if keep option is true, the function evaluates the continued fraction wit 'keep': true }); - t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' ); actual = continuedFraction( generator2(), { 'keep': true }); expected = 1.525135276160983; - t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 13 ), true, 'returns expected value' ); t.end(); // Continued fraction for (I_1(2))/(I_0(2)), see http://mathworld.wolfram.com/ContinuedFraction.html: @@ -132,14 +131,14 @@ tape( 'if keep option is true, the function evaluates the continued fraction wit 'keep': true }); - t.ok( abs( actual - expected ) < EPS, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 0 ), true, 'returns expected value' ); actual = continuedFractionBasic( generator2(), { 'keep': true }); expected = 1.525135276160983; - t.ok( abs( actual - expected ) < 1e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected, 13 ), true, 'returns expected value' ); t.end(); // Continued fraction for (I_1(2))/(I_0(2)), see http://mathworld.wolfram.com/ContinuedFraction.html: From 005b44bb36d0fdad37d277dd1b59622a878312f0 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 26 Sep 2026 23:29:09 -0700 Subject: [PATCH 2/3] style: disable lint rule Signed-off-by: Athan --- .../tools/continued-fraction/test/es2015-generator/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js index 1efde7819426..8a4e1e2782a4 100644 --- a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js +++ b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js @@ -18,7 +18,7 @@ 'use strict'; -/* eslint-disable no-restricted-syntax */ +/* eslint-disable n/no-unsupported-features/es-syntax */ // MODULES // From e7d71fd09bf6f14e97a79c77be0af995b26c46c2 Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 26 Sep 2026 23:34:07 -0700 Subject: [PATCH 3/3] style: disable lint rule Signed-off-by: Athan --- .../tools/continued-fraction/test/es2015-generator/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js index 8a4e1e2782a4..dd67cbc73a50 100644 --- a/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js +++ b/lib/node_modules/@stdlib/math/base/tools/continued-fraction/test/es2015-generator/index.js @@ -18,7 +18,7 @@ 'use strict'; -/* eslint-disable n/no-unsupported-features/es-syntax */ +/* eslint-disable no-restricted-syntax, n/no-unsupported-features/es-syntax */ // MODULES //