From 1b50643579fe6ee627e9fd431ac726936ec580cd Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 06:29:49 +0000 Subject: [PATCH] test: migrate `stats/incr/nanpcorrdist` to ULP-based assertions Replace the computed relative-tolerance assertions in the fixture loops with `@stdlib/assert/is-almost-same-value`, tightening each bound to the measured minimum of 1 ULP. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_014QE38pmPPF6BwZwAtSzV7e --- .../stats/incr/nanpcorrdist/test/test.js | 23 +++---------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/incr/nanpcorrdist/test/test.js b/lib/node_modules/@stdlib/stats/incr/nanpcorrdist/test/test.js index 1f825b43c4e9..2c3b6b6a4a0b 100644 --- a/lib/node_modules/@stdlib/stats/incr/nanpcorrdist/test/test.js +++ b/lib/node_modules/@stdlib/stats/incr/nanpcorrdist/test/test.js @@ -21,8 +21,7 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var incrnanpcorrdist = require( './../lib' ); @@ -99,8 +98,6 @@ tape( 'the function returns an accumulator function (known means)', function tes tape( 'the accumulator function incrementally computes a sample correlation distance', function test( t ) { var expected; var actual; - var delta; - var tol; var acc; var x; var y; @@ -124,13 +121,7 @@ tape( 'the accumulator function incrementally computes a sample correlation dist for ( i = 0; i < x.length; i++ ) { actual = acc( x[ i ], y[ i ] ); - if ( actual === expected[ i ] ) { - t.strictEqual( actual, expected[ i ], 'returns expected result. x: '+x[i]+'. y: '+y[i]+'.' ); - } else { - delta = abs( expected[ i ] - actual ); - tol = 3.7 * EPS * abs( expected[ i ] ); - t.equal( delta <= tol, true, 'x: '+x[i]+'. y: '+y[i]+'. expected: '+expected[i]+'. actual: '+actual+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( actual, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); @@ -138,8 +129,6 @@ tape( 'the accumulator function incrementally computes a sample correlation dist tape( 'the accumulator function incrementally computes a sample correlation distance (known means)', function test( t ) { var expected; var actual; - var delta; - var tol; var acc; var x; var y; @@ -163,13 +152,7 @@ tape( 'the accumulator function incrementally computes a sample correlation dist for ( i = 0; i < x.length; i++ ) { actual = acc( x[ i ], y[ i ] ); - if ( actual === expected[ i ] ) { - t.strictEqual( actual, expected[ i ], 'returns expected result. x: '+x[i]+'. y: '+y[i]+'.' ); - } else { - delta = abs( expected[ i ] - actual ); - tol = EPS * abs( expected[ i ] ); - t.equal( delta <= tol, true, 'x: '+x[i]+'. y: '+y[i]+'. expected: '+expected[i]+'. actual: '+actual+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( actual, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });