From 2a68d04f81cfcb712ebcc166c668bd18b5efc8a1 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 04:46:50 +0000 Subject: [PATCH 1/3] docs: fix description in `_tools/makie/plugins/makie-benchmark-lang` The plugin description in `lib/main.js` read "Plugin to run benchmarks.", which is byte-identical to the description in `makie-benchmark` and therefore describes the wrong plugin. Both `lib/index.js` and the package `description` field already read "...run cross-language benchmarks.", and the invoked `benchmark-lang` Makefile target is documented as "Runs cross-language benchmarks." Corrected drift item: - Synchronized the `lib/main.js` plugin description with `lib/index.js` and `package.json` (20 of 23 siblings, 87%, keep the three in agreement). Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_019jbKvYDh4CASxMJWBErc42 --- .../_tools/makie/plugins/makie-benchmark-lang/lib/main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/_tools/makie/plugins/makie-benchmark-lang/lib/main.js b/lib/node_modules/@stdlib/_tools/makie/plugins/makie-benchmark-lang/lib/main.js index 2522f7fbfe7e..f9b307537247 100644 --- a/lib/node_modules/@stdlib/_tools/makie/plugins/makie-benchmark-lang/lib/main.js +++ b/lib/node_modules/@stdlib/_tools/makie/plugins/makie-benchmark-lang/lib/main.js @@ -75,7 +75,7 @@ function stderr( data ) { // MAIN // /** -* Plugin to run benchmarks. +* Plugin to run cross-language benchmarks. * * @param {string} dir - Makefile directory * @param {string} cwd - current working directory From f9713eb84c72c48dc828e8b2c2cf1a6187bb070e Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 04:47:43 +0000 Subject: [PATCH 2/3] docs: fix description in `_tools/makie/plugins/makie-repl` The plugin description in `lib/main.js` read "Plugin for launching a REPL.", while `lib/index.js` and the package `description` field both read "...to launch a REPL." Corrected drift items: - Synchronized the `lib/main.js` plugin description with `lib/index.js` and `package.json` (20 of 23 siblings, 87%, keep the three in agreement). - Adopted the "Plugin to " phrasing used by 22 of 23 siblings (96%); this was the only description opening with "Plugin for". Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_019jbKvYDh4CASxMJWBErc42 --- .../@stdlib/_tools/makie/plugins/makie-repl/lib/main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/_tools/makie/plugins/makie-repl/lib/main.js b/lib/node_modules/@stdlib/_tools/makie/plugins/makie-repl/lib/main.js index c8375ebc84af..32f98249b125 100644 --- a/lib/node_modules/@stdlib/_tools/makie/plugins/makie-repl/lib/main.js +++ b/lib/node_modules/@stdlib/_tools/makie/plugins/makie-repl/lib/main.js @@ -26,7 +26,7 @@ var spawn = require( 'child_process' ).spawn; // MAIN // /** -* Plugin for launching a REPL. +* Plugin to launch a REPL. * * @param {string} dir - Makefile directory * @param {string} cwd - current working directory From 6675fd782e9eb02b459b73eb8c6b4a8cad590ff9 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 04:47:54 +0000 Subject: [PATCH 3/3] refactor: build args via push in `_tools/makie/plugins/makie-view-cov` The plugin initialized its `make` argument list with an array literal containing the target (`args = [ 'view-cov' ];`) rather than initializing an empty array and pushing the target, as every other plugin in the namespace does. The sibling `makie-view-complexity` was converted to the empty-array-and-push form when `stdlib/no-new-array` lint errors were fixed; this plugin was not, because an array literal does not trigger that rule. Corrected drift item: - Initialize `args` as an empty array and append the target via `args.push` (22 of 23 siblings, 96%). The spawned command is unchanged. Intercepting `child_process.spawn` before and after yields an identical invocation: { cmd: 'make', args: [ 'view-cov' ], opts: { cwd: } } Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_019jbKvYDh4CASxMJWBErc42 --- .../@stdlib/_tools/makie/plugins/makie-view-cov/lib/main.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/_tools/makie/plugins/makie-view-cov/lib/main.js b/lib/node_modules/@stdlib/_tools/makie/plugins/makie-view-cov/lib/main.js index 2e633ddb5c3f..c3a17f2a8ff0 100644 --- a/lib/node_modules/@stdlib/_tools/makie/plugins/makie-view-cov/lib/main.js +++ b/lib/node_modules/@stdlib/_tools/makie/plugins/makie-view-cov/lib/main.js @@ -89,8 +89,10 @@ function plugin( dir ) { opts = {}; opts.cwd = dir; + args = []; + // Target: - args = [ 'view-cov' ]; + args.push( 'view-cov' ); proc = spawn( 'make', args, opts ); proc.on( 'error', onError );