From 4cd9320f88d283ab2ec9a175890613e5f5689f8b Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 25 Sep 2026 18:25:14 +0000 Subject: [PATCH] test: migrate `stats/base/dists/geometric/logpmf` to ULP-based assertions Migrates the test suite for `stats/base/dists/geometric/logpmf` from relative tolerance assertions to ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The ULP bounds were tightened to the measured minimum over the full fixture sets: 1 ULP for the small `p` fixtures and 2 ULP for the large `p` fixtures (for both the JavaScript and C implementations). Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_016qDBdX4stVDGqj5ywZ7uwf --- .../geometric/logpmf/test/test.factory.js | 23 +++---------------- .../geometric/logpmf/test/test.logpmf.js | 23 +++---------------- .../geometric/logpmf/test/test.native.js | 23 +++---------------- 3 files changed, 9 insertions(+), 60 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.factory.js index 59bcf70ae5a0..1d90684e4d84 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -138,8 +137,6 @@ tape( 'if provided a `p` outside of `[0,1]`, the created function always returns tape( 'the created function evaluates the logpmf for `x` given small `p`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var i; var p; var x; @@ -151,13 +148,7 @@ tape( 'the created function evaluates the logpmf for `x` given small `p`', funct for ( i = 0; i < x.length; i++ ) { logpmf = factory( p[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); @@ -165,8 +156,6 @@ tape( 'the created function evaluates the logpmf for `x` given small `p`', funct tape( 'the function evaluates the logpmf for `x` given large `p`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var p; var x; var y; @@ -178,13 +167,7 @@ tape( 'the function evaluates the logpmf for `x` given large `p`', function test for ( i = 0; i < x.length; i++ ) { logpmf = factory( p[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.5 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.logpmf.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.logpmf.js index 5018360789d8..cdf36d7ac2c7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.logpmf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.logpmf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logpmf = require( './../lib' ); @@ -97,8 +96,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function al tape( 'the function evaluates the logpmf for `x` given small parameter `p`', function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -109,21 +106,13 @@ tape( 'the function evaluates the logpmf for `x` given small parameter `p`', fun p = smallP.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. p:'+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given large parameter `p`', function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -134,13 +123,7 @@ tape( 'the function evaluates the logpmf for `x` given large parameter `p`', fun p = largeP.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.5 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.native.js index e2b4595b97ae..119abaebc147 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -106,8 +105,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function al tape( 'the function evaluates the logpmf for `x` given small parameter `p`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -118,21 +115,13 @@ tape( 'the function evaluates the logpmf for `x` given small parameter `p`', opt p = smallP.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. p:'+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given large parameter `p`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -143,13 +132,7 @@ tape( 'the function evaluates the logpmf for `x` given large parameter `p`', opt p = largeP.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.5 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });