From eb54996804db2d81cea3ecf6abf3d25b3b4940f7 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Thu, 24 Sep 2026 06:33:15 +0000 Subject: [PATCH] test: migrate `stats/base/dists/weibull/skewness` to ULP-based assertions Replace the relative tolerance assertions in `test/test.js` and `test/test.native.js` with `@stdlib/assert/is-almost-same-value`, using the minimum ULP bound which passes over the full fixture set. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012ZDpXGX4VLAhBiWQNHMi81 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/weibull/skewness/test/test.js | 12 ++---------- .../base/dists/weibull/skewness/test/test.native.js | 12 ++---------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.js index f636c98841da..65c0d25f429b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.js @@ -21,7 +21,7 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); @@ -96,8 +96,6 @@ tape( 'if provided `lambda <= 0`, the function returns `NaN`', function test( t tape( 'the function returns the skewness of a Weibull distribution', function test( t ) { var expected; var lambda; - var delta; - var tol; var k; var i; var y; @@ -107,13 +105,7 @@ tape( 'the function returns the skewness of a Weibull distribution', function te lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = skewness( k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k: '+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1e-11 * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 36208 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.native.js index 55cf3362ea22..dd6e11e30001 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/test/test.native.js @@ -23,7 +23,7 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); @@ -105,8 +105,6 @@ tape( 'if provided `lambda <= 0`, the function returns `NaN`', opts, function te tape( 'the function returns the skewness of a Weibull distribution', opts, function test( t ) { var expected; var lambda; - var delta; - var tol; var k; var i; var y; @@ -116,13 +114,7 @@ tape( 'the function returns the skewness of a Weibull distribution', opts, funct lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = skewness( k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k: '+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1e-11 * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 36208 ), true, 'returns expected value' ); } t.end(); });