From 71d610a071d797c2f1c235f1abef26d91c541ee9 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Tue, 22 Sep 2026 22:24:59 +0000 Subject: [PATCH] test: migrate `stats/base/dists/normal/pdf` to ULP-based assertions Migrate the tests for `stats/base/dists/normal/pdf` from relative tolerance assertions to ULP difference assertions using `@stdlib/assert/is-almost-same-value`. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01AFE6m4JZPfvHrCqv6553Sp --- .../base/dists/normal/pdf/test/test.factory.js | 17 ++++------------- .../base/dists/normal/pdf/test/test.native.js | 15 +++------------ .../base/dists/normal/pdf/test/test.pdf.js | 15 +++------------ 3 files changed, 10 insertions(+), 37 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.factory.js index 4a1340e47405..919fe35788e5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.factory.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -154,10 +153,8 @@ tape( 'if `sigma` equals `0`, the created function evaluates a degenerate distri tape( 'the created function evaluates the pdf for `x` given parameters `mu` and `sigma`', function test( t ) { var expected; - var delta; var sigma; var pdf; - var tol; var mu; var x; var y; @@ -168,15 +165,9 @@ tape( 'the created function evaluates the pdf for `x` given parameters `mu` and mu = data.mu; sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { - pdf = factory( mu[i], sigma[i] ); - y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 5300.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + pdf = factory( mu[ i ], sigma[ i ] ); + y = pdf( x[ i ] ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 250 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.native.js index dbde75a1bb5c..7c632f38d9dc 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.native.js @@ -23,10 +23,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -137,9 +136,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the pdf for `x` given parameters `mu` and `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var x; var y; @@ -150,14 +147,8 @@ tape( 'the function evaluates the pdf for `x` given parameters `mu` and `sigma`' mu = data.mu; sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { - y = pdf( x[i], mu[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 5300.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + y = pdf( x[ i ], mu[ i ], sigma[ i ] ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 250 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.pdf.js b/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.pdf.js index c3002d93f203..8d9bd8212ed3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.pdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/test/test.pdf.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var pdf = require( './../lib' ); @@ -128,9 +127,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the pdf for `x` given parameters `mu` and `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var x; var y; @@ -141,14 +138,8 @@ tape( 'the function evaluates the pdf for `x` given parameters `mu` and `sigma`' mu = data.mu; sigma = data.sigma; for ( i = 0; i < x.length; i++ ) { - y = pdf( x[i], mu[i], sigma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 5300.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + y = pdf( x[ i ], mu[ i ], sigma[ i ] ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 250 ), true, 'returns expected value' ); } t.end(); });