From 95a805b29fe6c048fccb25f2fc33f0110a3bee3f Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 22 Sep 2026 02:26:53 +0000 Subject: [PATCH] test: migrate `stats/base/dists/discrete-uniform/logcdf` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01TtwLeeyjW9sBGNpfzDijtV --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../logcdf/test/test.factory.js | 33 +++---------------- .../logcdf/test/test.logcdf.js | 33 +++---------------- .../logcdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.factory.js index d84aa6eefbb6..6ca211af9622 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -144,8 +143,6 @@ tape( 'if provided a `a > b`, the created function always returns `NaN`', functi tape( 'the created function evaluates the logcdf for `x` given a small range `b - a`', function test( t ) { var expected; var logcdf; - var delta; - var tol; var a; var b; var i; @@ -159,13 +156,7 @@ tape( 'the created function evaluates the logcdf for `x` given a small range `b for ( i = 0; i < x.length; i++ ) { logcdf = factory( a[i], b[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 110.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 41 ), true, 'returns expected value' ); } t.end(); }); @@ -173,8 +164,6 @@ tape( 'the created function evaluates the logcdf for `x` given a small range `b tape( 'the created function evaluates the logcdf for `x` given a medium range `b - a`', function test( t ) { var expected; var logcdf; - var delta; - var tol; var a; var b; var i; @@ -188,13 +177,7 @@ tape( 'the created function evaluates the logcdf for `x` given a medium range `b for ( i = 0; i < x.length; i++ ) { logcdf = factory( a[i], b[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 80.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 100 ), true, 'returns expected value' ); } t.end(); }); @@ -202,8 +185,6 @@ tape( 'the created function evaluates the logcdf for `x` given a medium range `b tape( 'the created function evaluates the logcdf for `x` given a large range `b - a`', function test( t ) { var expected; var logcdf; - var delta; - var tol; var a; var b; var i; @@ -217,13 +198,7 @@ tape( 'the created function evaluates the logcdf for `x` given a large range `b for ( i = 0; i < x.length; i++ ) { logcdf = factory( a[i], b[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 150.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 156 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.logcdf.js index 7a6e1a8cd689..0cf8dffb24cf 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.logcdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logcdf = require( './../lib' ); @@ -93,8 +92,6 @@ tape( 'if provided `a > b`, the function returns `NaN`', function test( t ) { tape( 'the function evaluates the logcdf for `x` given a small range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -107,21 +104,13 @@ tape( 'the function evaluates the logcdf for `x` given a small range `b - a`', f b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 110.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 41 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given a medium range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -134,21 +123,13 @@ tape( 'the function evaluates the logcdf for `x` given a medium range `b - a`', b = mediumRange.b; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 80.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 100 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given a large range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -161,13 +142,7 @@ tape( 'the function evaluates the logcdf for `x` given a large range `b - a`', f b = largeRange.b; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 150.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 156 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.native.js index 9b7e82eed29b..bb88bbe18610 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logcdf/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -79,8 +78,6 @@ tape( 'if provided `a > b`, the function returns `NaN`', opts, function test( t tape( 'the function evaluates the logcdf for `x` given a small range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -93,21 +90,13 @@ tape( 'the function evaluates the logcdf for `x` given a small range `b - a`', o b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 110.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 41 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given a medium range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -120,21 +109,13 @@ tape( 'the function evaluates the logcdf for `x` given a medium range `b - a`', b = mediumRange.b; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 80.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 100 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given a large range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -147,13 +128,7 @@ tape( 'the function evaluates the logcdf for `x` given a large range `b - a`', o b = largeRange.b; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 150.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 156 ), true, 'returns expected value' ); } t.end(); });