From 7736999de0e5e39a9ab7a718999aac28da04cd7a Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 21 Sep 2026 10:15:21 +0000 Subject: [PATCH] test: migrate `stats/base/dists/chisquare/cdf` to ULP-based assertions Migrates the tests for `stats/base/dists/chisquare/cdf` from relative tolerance testing to ULP difference testing. The ULP constant is the measured minimum over the full 5000-element `decimal_decimal.json` fixture set: - `decimal_decimal.json`: 76 (was `40.0 * EPS * abs( expected[i] )`) The native add-on was built locally and reproduces the JavaScript results bit-for-bit across all 5000 fixtures, so `test/test.native.js` uses the same constant. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_018DyJPRsZzRLQLN4sSHtZjY --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/chisquare/cdf/test/test.cdf.js | 13 ++----------- .../base/dists/chisquare/cdf/test/test.factory.js | 13 ++----------- .../base/dists/chisquare/cdf/test/test.native.js | 13 ++----------- 3 files changed, 6 insertions(+), 33 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.cdf.js b/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.cdf.js index 62123dc1b3ca..3c267d0a1aeb 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.cdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.cdf.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var cdf = require( './../lib' ); @@ -103,8 +102,6 @@ tape( 'if provided a `k` equal to `0`, the function evaluates a degenerate distr tape( 'the function evaluates the cdf for `x` given degrees of freedom `k`', function test( t ) { var expected; - var delta; - var tol; var x; var k; var y; @@ -115,13 +112,7 @@ tape( 'the function evaluates the cdf for `x` given degrees of freedom `k`', fun k = decimalDecimal.k; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], k[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', k:'+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 76 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.factory.js index 6231de748b9a..f47676bda06a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.factory.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -129,9 +128,7 @@ tape( 'if `k` equals `0`, the created function evaluates a degenerate distributi tape( 'the created function evaluates the cdf for `x` given degrees of freedom `k`', function test( t ) { var expected; - var delta; var cdf; - var tol; var x; var k; var y; @@ -143,13 +140,7 @@ tape( 'the created function evaluates the cdf for `x` given degrees of freedom ` for ( i = 0; i < x.length; i++ ) { cdf = factory( k[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', k:'+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 76 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.native.js index 7f0b5c78bc81..ec9facb81180 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -92,8 +91,6 @@ tape( 'if provided a negative `k`, the function returns `NaN`', opts, function t tape( 'the function evaluates the cdf for `x` given `k`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var k; var y; @@ -104,13 +101,7 @@ tape( 'the function evaluates the cdf for `x` given `k`', opts, function test( t k = decimalDecimal.k; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], k[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', k: '+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 76 ), true, 'returns expected value' ); } t.end(); });