From 4950b9d914aedeb84ad851d7ca9733952327a5a4 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 18 Sep 2026 14:23:41 +0000 Subject: [PATCH] test: migrate `stats/base/dists/geometric/logcdf` to ULP-based assertions Migrate the package tests from relative tolerance testing to ULP difference testing. The ULP constants are the measured minimums over the full fixtures: 15 for `small_p.json` and 42 for `large_p.json`. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01F16PRh9EwFCQffzr6sRWrN --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../geometric/logcdf/test/test.factory.js | 23 +++---------------- .../geometric/logcdf/test/test.logcdf.js | 23 +++---------------- .../geometric/logcdf/test/test.native.js | 23 +++---------------- 3 files changed, 9 insertions(+), 60 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.factory.js index 4bb138f34a3a..866008c5627d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -122,8 +121,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the created fun tape( 'the created function evaluates the logcdf for `x` given small parameter `p`', function test( t ) { var expected; var logcdf; - var delta; - var tol; var x; var p; var y; @@ -135,13 +132,7 @@ tape( 'the created function evaluates the logcdf for `x` given small parameter ` for ( i = 0; i < x.length; i++ ) { logcdf = factory( p[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 15 ), true, 'returns expected value' ); } t.end(); }); @@ -149,8 +140,6 @@ tape( 'the created function evaluates the logcdf for `x` given small parameter ` tape( 'the created function evaluates the logcdf for `x` given large parameter `p`', function test( t ) { var expected; var logcdf; - var delta; - var tol; var x; var p; var y; @@ -162,13 +151,7 @@ tape( 'the created function evaluates the logcdf for `x` given large parameter ` for ( i = 0; i < x.length; i++ ) { logcdf = factory( p[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 30.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 42 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.logcdf.js index 2923e9423d34..a1eb8303fa33 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.logcdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logcdf = require( './../lib' ); @@ -90,8 +89,6 @@ tape( 'if provided a value outside `[0,1]` for success probability `p`, the func tape( 'the function evaluates the logcdf for `x` given small parameter `p`', function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -102,21 +99,13 @@ tape( 'the function evaluates the logcdf for `x` given small parameter `p`', fun p = smallP.p; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 15 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given large parameter `p`', function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -127,13 +116,7 @@ tape( 'the function evaluates the logcdf for `x` given large parameter `p`', fun p = largeP.p; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 30.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 42 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.native.js index 694ea7290881..d02da5ac3f1b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/logcdf/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -99,8 +98,6 @@ tape( 'if provided a value outside `[0,1]` for success probability `p`, the func tape( 'the function evaluates the logcdf for `x` given small parameter `p`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -111,21 +108,13 @@ tape( 'the function evaluates the logcdf for `x` given small parameter `p`', opt p = smallP.p; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 15 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given large parameter `p`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var p; var y; @@ -136,13 +125,7 @@ tape( 'the function evaluates the logcdf for `x` given large parameter `p`', opt p = largeP.p; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 30.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 42 ), true, 'returns expected value' ); } t.end(); });