From 22dbd1d4686882165bca5ffa786c858de35d08ea Mon Sep 17 00:00:00 2001 From: Abhist17 Date: Thu, 17 Sep 2026 14:35:54 +0530 Subject: [PATCH 1/2] chore: fix JavaScript lint errors (issue #15228) Symbol.toPrimitive comparison in the "@stdlib/symbol/to-primitive" test trips n/no-unsupported-features/es-builtins: the package's engines range is >=0.12.18 (pre-ES6) and the rule flags any bare Symbol.toPrimitive reference regardless of the runtime guard already in place. The access is already environment-safe -- opts.skip (from hasToPrimitiveSymbolSupport()) prevents the assertion from running where the symbol doesn't exist. Suppress with an inline eslint-disable-line, matching the same rule/scenario already handled this way in utils/property-descriptors/test/test.builtin.js and assert/is-number/test/test.object.js. --- lib/node_modules/@stdlib/symbol/to-primitive/test/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js b/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js index 25c4f77a0fa7..656f628f9e3f 100644 --- a/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js +++ b/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js @@ -48,6 +48,6 @@ tape( 'main export is a symbol in supporting environments (ES6/2015+) or otherwi }); tape( 'the main export is an alias for `Symbol.toPrimitive`', opts, function test( t ) { - t.strictEqual( Sym, Symbol.toPrimitive, 'returns expected value' ); + t.strictEqual( Sym, Symbol.toPrimitive, 'returns expected value' ); // eslint-disable-line n/no-unsupported-features/es-builtins t.end(); }); From 1366ec8a228631d96a77bc0834a7ce862411dea5 Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 23 Sep 2026 01:54:19 -0700 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- lib/node_modules/@stdlib/symbol/to-primitive/test/test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js b/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js index 656f628f9e3f..3e8c15be7bcc 100644 --- a/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js +++ b/lib/node_modules/@stdlib/symbol/to-primitive/test/test.js @@ -21,7 +21,7 @@ // MODULES // var tape = require( 'tape' ); -var hasToPrimitiveSymbolSupport = require( '@stdlib/assert/has-to-primitive-symbol-support' ); +var hasToPrimitiveSymbolSupport = require( '@stdlib/assert/has-to-primitive-symbol-support' ); // eslint-disable-line id-length var isSymbol = require( '@stdlib/assert/is-symbol' ); var Symbol = require( '@stdlib/symbol/ctor' ); var Sym = require( './../lib' ); @@ -48,6 +48,6 @@ tape( 'main export is a symbol in supporting environments (ES6/2015+) or otherwi }); tape( 'the main export is an alias for `Symbol.toPrimitive`', opts, function test( t ) { - t.strictEqual( Sym, Symbol.toPrimitive, 'returns expected value' ); // eslint-disable-line n/no-unsupported-features/es-builtins + t.strictEqual( Sym, Symbol.toPrimitive, 'returns expected value' ); t.end(); });