From b55ea04c7b2f6fb2eb67ab3e435085ceec1f2522 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Sun, 6 Sep 2026 18:12:12 +0000 Subject: [PATCH] test: migrate `stats/base/dists/hypergeometric/skewness` to ULP-based assertions Replaces relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The maximum observed ULP difference over the fixture set is 1 for both the JavaScript and native implementations, so 1 is the minimum bound which passes. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_0132ozAreeH8GYagxGFNNVvX --- .../base/dists/hypergeometric/skewness/test/test.js | 13 ++----------- .../hypergeometric/skewness/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.js index 7d9914dc0658..6a63a03afbc7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.js @@ -21,10 +21,9 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var skewness = require( './../lib' ); @@ -119,8 +118,6 @@ tape( 'if provided an `n` which is not a nonnegative integer, the function retur tape( 'the function returns the skewness of a hypergeometric distribution', function test( t ) { var expected; - var delta; - var tol; var N; var K; var n; @@ -133,13 +130,7 @@ tape( 'the function returns the skewness of a hypergeometric distribution', func n = data.n; for ( i = 0; i < n.length; i++ ) { y = skewness( N[i], K[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.native.js index 768d40895fd5..c94745baca2f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/test/test.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -87,8 +86,6 @@ tape( 'if provided an `n` which is not a nonnegative integer, the function retur tape( 'the function returns the skewness of a hypergeometric distribution', opts, function test( t ) { var expected; - var delta; - var tol; var N; var K; var n; @@ -101,13 +98,7 @@ tape( 'the function returns the skewness of a hypergeometric distribution', opts n = data.n; for ( i = 0; i < n.length; i++ ) { y = skewness( N[i], K[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });