From 1192cfaa2b0d593491de6e7eaeb9c5deb2663e28 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 30 Aug 2026 09:15:36 +0000 Subject: [PATCH] test: migrate `stats/base/dists/weibull/mean` to ULP-based assertions Replaces the EPS-based relative-tolerance comparison in test.js and test.native.js with a ULP-difference comparison via @stdlib/assert/is-almost-same-value, tightened to the minimum ULP bound (4) that still passes over the full fixture set. Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/weibull/mean/test/test.js | 13 ++----------- .../base/dists/weibull/mean/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.js index cd47f335ed5b..19849a94f339 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var mean = require( './../lib' ); @@ -97,8 +96,6 @@ tape( 'if provided `lambda <= 0`, the function returns `NaN`', function test( t tape( 'the function returns the mean of a Weibull distribution', function test( t ) { var expected; var lambda; - var delta; - var tol; var k; var i; var y; @@ -108,13 +105,7 @@ tape( 'the function returns the mean of a Weibull distribution', function test( lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = mean( k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k: '+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 4 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.native.js index 97115cb84d24..4578bc2f97f9 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/weibull/mean/test/test.native.js @@ -23,11 +23,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -106,8 +105,6 @@ tape( 'if provided `lambda <= 0`, the function returns `NaN`', opts, function te tape( 'the function returns the mean of a Weibull distribution', opts, function test( t ) { var expected; var lambda; - var delta; - var tol; var k; var i; var y; @@ -117,13 +114,7 @@ tape( 'the function returns the mean of a Weibull distribution', opts, function lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = mean( k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k: '+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 4 ), true, 'returns expected value' ); } t.end(); });