From d2f811b75a5b68d759e535b345f1f09aaf31dfec Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Sun, 30 Aug 2026 02:19:34 +0000 Subject: [PATCH] test: migrate `stats/base/dists/planck/skewness` to ULP-based assertions Replaces relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of 1 ULP over the full Python fixture set. Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- .../stats/base/dists/planck/skewness/test/test.js | 13 ++----------- .../dists/planck/skewness/test/test.native.js | 15 +++------------ 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.js index c7d06df9f620..593da478a136 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.js @@ -21,9 +21,8 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var skewness = require( './../lib' ); @@ -61,8 +60,6 @@ tape( 'if provided a shape parameter `lambda` which is nonpositive, the function tape( 'the function returns the skewness of a Planck distribution', function test( t ) { var expected; var lambda; - var delta; - var tol; var i; var y; @@ -70,13 +67,7 @@ tape( 'the function returns the skewness of a Planck distribution', function tes lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = skewness( lambda[ i ] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'lambda: '+lambda[ i ]+', y: '+y+', expected: '+expected[ i ] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. lambda: '+lambda[ i ]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.native.js index 597447a68175..66401c4fdc70 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/planck/skewness/test/test.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); // FIXTURES // @@ -70,8 +69,6 @@ tape( 'if provided a shape parameter `lambda` which is nonpositive, the function tape( 'the function returns the skewness of a Planck distribution', opts, function test( t ) { var expected; var lambda; - var delta; - var tol; var i; var y; @@ -79,13 +76,7 @@ tape( 'the function returns the skewness of a Planck distribution', opts, functi lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = skewness( lambda[ i ] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'lambda: '+lambda[ i ]+', y: '+y+', expected: '+expected[ i ] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. lambda: '+lambda[ i ]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });