From f045e25fc87552850175084e991ffc334586fe3b Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 28 Aug 2026 14:29:33 +0000 Subject: [PATCH] test: migrate `stats/base/dists/betaprime/kurtosis` to ULP-based assertions Replace the relative tolerance assertions in the fixture loops of `test/test.js` and `test/test.native.js` with `isAlmostSameValue` ULP difference assertions. The ULP bound was tightened to the measured minimum of 369 for both the JavaScript and C implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_013gUyuE14QfhKCjNXJ7RSJj --- .../base/dists/betaprime/kurtosis/test/test.js | 13 ++----------- .../dists/betaprime/kurtosis/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.js index c8200ac103ba..63a814fa19ed 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var kurtosis = require( './../lib' ); @@ -111,10 +110,8 @@ tape( 'if provided `beta <= 4`, the function returns `NaN`', function test( t ) tape( 'the function returns the excess kurtosis of a beta prime distribution', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var y; @@ -123,13 +120,7 @@ tape( 'the function returns the excess kurtosis of a beta prime distribution', f beta = data.beta; for ( i = 0; i < expected.length; i++ ) { y = kurtosis( alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 320.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 369 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.native.js index 52d0a23ead30..834304d69bf6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -120,10 +119,8 @@ tape( 'if provided `beta <= 4`, the function returns `NaN`', opts, function test tape( 'the function returns the excess kurtosis of a beta prime distribution', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var y; @@ -132,13 +129,7 @@ tape( 'the function returns the excess kurtosis of a beta prime distribution', o beta = data.beta; for ( i = 0; i < expected.length; i++ ) { y = kurtosis( alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 320.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 369 ), true, 'returns expected value' ); } t.end(); });