From f8322a959edbffade5eb61e43126ac152f6ecf16 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 27 Aug 2026 22:20:15 +0000 Subject: [PATCH] test: migrate `stats/base/dists/rayleigh/quantile` to ULP-based assertions Replace relative tolerance (`EPS`/`delta`/`tol`) assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound is the measured minimum over the full fixture sets: `small_scale` (1), `medium_scale` (1), and `large_scale` (1). The JavaScript and C implementations return bit-identical results for every fixture value, so `test/test.native.js` uses the same bounds. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01WDdta6rnNBBxqNpFpzZVHi --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../rayleigh/quantile/test/test.factory.js | 39 ++----------------- .../rayleigh/quantile/test/test.native.js | 39 ++----------------- .../rayleigh/quantile/test/test.quantile.js | 39 ++----------------- 3 files changed, 12 insertions(+), 105 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.factory.js index 81bc4eca556e..e1a26dc66571 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.factory.js @@ -21,10 +21,9 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -121,9 +120,7 @@ tape( 'if `sigma` equals `0`, the created function evaluates a degenerate distri tape( 'the created function evaluates the quantile function at `p` given small scale parameter `sigma`', function test( t ) { var expected; var quantile; - var delta; var sigma; - var tol; var i; var p; var y; @@ -134,15 +131,7 @@ tape( 'the created function evaluates the quantile function at `p` given small s for ( i = 0; i < p.length; i++ ) { quantile = factory( sigma[i] ); y = quantile( p[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); @@ -150,9 +139,7 @@ tape( 'the created function evaluates the quantile function at `p` given small s tape( 'the created function evaluates the quantile function at `p` given medium scale parameter `sigma`', function test( t ) { var expected; var quantile; - var delta; var sigma; - var tol; var i; var p; var y; @@ -163,15 +150,7 @@ tape( 'the created function evaluates the quantile function at `p` given medium for ( i = 0; i < p.length; i++ ) { quantile = factory( sigma[i] ); y = quantile( p[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); @@ -179,9 +158,7 @@ tape( 'the created function evaluates the quantile function at `p` given medium tape( 'the created function evaluates the quantile function at `p` given large scale parameter `sigma`', function test( t ) { var expected; var quantile; - var delta; var sigma; - var tol; var i; var p; var y; @@ -192,15 +169,7 @@ tape( 'the created function evaluates the quantile function at `p` given large s for ( i = 0; i < p.length; i++ ) { quantile = factory( sigma[i] ); y = quantile( p[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.native.js index 76520282c92a..05291a52ff73 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -103,9 +102,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the quantile function at `p` given small scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var p; var y; @@ -115,24 +112,14 @@ tape( 'the function evaluates the quantile function at `p` given small scale par sigma = smallScale.sigma; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], sigma[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile function at `p` given medium scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var p; var y; @@ -142,24 +129,14 @@ tape( 'the function evaluates the quantile function at `p` given medium scale pa sigma = mediumScale.sigma; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], sigma[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile function at `p` given large scale parameter `sigma`', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var p; var y; @@ -169,15 +146,7 @@ tape( 'the function evaluates the quantile function at `p` given large scale par sigma = largeScale.sigma; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], sigma[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.quantile.js b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.quantile.js index ea60e5071710..bf57f9569c94 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.quantile.js +++ b/lib/node_modules/@stdlib/stats/base/dists/rayleigh/quantile/test/test.quantile.js @@ -21,10 +21,9 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var quantile = require( './../lib' ); @@ -94,9 +93,7 @@ tape( 'if provided `sigma` equals `0`, the function evaluates a degenerate distr tape( 'the function evaluates the quantile function at `p` given small scale parameter `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var p; var y; @@ -106,24 +103,14 @@ tape( 'the function evaluates the quantile function at `p` given small scale par sigma = smallScale.sigma; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], sigma[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile function at `p` given medium scale parameter `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var p; var y; @@ -133,24 +120,14 @@ tape( 'the function evaluates the quantile function at `p` given medium scale pa sigma = mediumScale.sigma; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], sigma[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile function at `p` given large scale parameter `sigma`', function test( t ) { var expected; - var delta; var sigma; - var tol; var i; var p; var y; @@ -160,15 +137,7 @@ tape( 'the function evaluates the quantile function at `p` given large scale par sigma = largeScale.sigma; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], sigma[i] ); - if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });