From f6bcbe2bea600227ec1b625c5d10dbeee013d941 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Thu, 27 Aug 2026 18:17:20 +0000 Subject: [PATCH] test: migrate `stats/base/dists/frechet/logcdf` to ULP-based assertions Replace relative tolerance (`EPS`/`delta`/`tol`) assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The ULP bounds are the measured minimums over the full fixture sets: `large_shape` (24), `large_scale` (2), and `both_large` (20). The JavaScript and C implementations return bit-identical results for every fixture value, so `test/test.native.js` uses the same bounds. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01QNXbmetYcbrxtMYbT4hMtS --- .../dists/frechet/logcdf/test/test.factory.js | 33 +++---------------- .../dists/frechet/logcdf/test/test.logcdf.js | 33 +++---------------- .../dists/frechet/logcdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.factory.js index def4a675bf35..5c1273ce65ba 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -154,8 +153,6 @@ tape( 'the created function evaluates the logcdf for `x` given large `alpha`', f var expected; var logcdf; var alpha; - var delta; - var tol; var s; var x; var y; @@ -168,13 +165,7 @@ tape( 'the created function evaluates the logcdf for `x` given large `alpha`', f for ( i = 0; i < x.length; i++ ) { logcdf = factory( alpha[i], s[i], 0.0 ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. m: 0. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 24 ), true, 'returns expected value' ); } t.end(); }); @@ -183,8 +174,6 @@ tape( 'the created function evaluates the logcdf for `x` given large `s`', funct var expected; var logcdf; var alpha; - var delta; - var tol; var s; var x; var y; @@ -197,13 +186,7 @@ tape( 'the created function evaluates the logcdf for `x` given large `s`', funct for ( i = 0; i < x.length; i++ ) { logcdf = factory( alpha[i], s[i], 0.0 ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha:'+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); @@ -212,8 +195,6 @@ tape( 'the created function evaluates the logcdf for `x` given large `alpha` and var expected; var logcdf; var alpha; - var delta; - var tol; var s; var x; var y; @@ -226,13 +207,7 @@ tape( 'the created function evaluates the logcdf for `x` given large `alpha` and for ( i = 0; i < x.length; i++ ) { logcdf = factory( alpha[i], s[i], 0.0 ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha:'+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 20 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.logcdf.js index c4e90a993351..cc2d7d54b96e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.logcdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logcdf = require( './../lib' ); @@ -135,8 +134,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', function test tape( 'the function evaluates the logcdf for `x` given large `alpha`', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var x; var y; @@ -148,13 +145,7 @@ tape( 'the function evaluates the logcdf for `x` given large `alpha`', function s = largeShape.s; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 24 ), true, 'returns expected value' ); } t.end(); }); @@ -162,8 +153,6 @@ tape( 'the function evaluates the logcdf for `x` given large `alpha`', function tape( 'the function evaluates the logcdf for `x` given large `s`', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var x; var y; @@ -175,13 +164,7 @@ tape( 'the function evaluates the logcdf for `x` given large `s`', function test s = largeScale.s; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); @@ -189,8 +172,6 @@ tape( 'the function evaluates the logcdf for `x` given large `s`', function test tape( 'the function evaluates the logcdf for `x` given large `alpha` and `s`', function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var x; var y; @@ -202,13 +183,7 @@ tape( 'the function evaluates the logcdf for `x` given large `alpha` and `s`', f s = bothLarge.s; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. m: 0. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 20 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.native.js index 8970b2bdcaa1..0c75be9d3d8d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -144,8 +143,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', opts, functio tape( 'the function evaluates the logcdf for `x` given large `alpha`', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var x; var y; @@ -157,13 +154,7 @@ tape( 'the function evaluates the logcdf for `x` given large `alpha`', opts, fun s = largeShape.s; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 24 ), true, 'returns expected value' ); } t.end(); }); @@ -171,8 +162,6 @@ tape( 'the function evaluates the logcdf for `x` given large `alpha`', opts, fun tape( 'the function evaluates the logcdf for `x` given large `s`', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var x; var y; @@ -184,13 +173,7 @@ tape( 'the function evaluates the logcdf for `x` given large `s`', opts, functio s = largeScale.s; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); @@ -198,8 +181,6 @@ tape( 'the function evaluates the logcdf for `x` given large `s`', opts, functio tape( 'the function evaluates the logcdf for `x` given large `alpha` and `s`', opts, function test( t ) { var expected; var alpha; - var delta; - var tol; var s; var x; var y; @@ -211,13 +192,7 @@ tape( 'the function evaluates the logcdf for `x` given large `alpha` and `s`', o s = bothLarge.s; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], alpha[i], s[i], 0.0 ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', s: '+s[i]+', m: 0, y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. s: '+s[i]+'. y: '+y+'. m: 0. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 20 ), true, 'returns expected value' ); } t.end(); });