From eff821e9f11b817c3d78091b61593f32913dec56 Mon Sep 17 00:00:00 2001 From: Aryan Kumar Date: Thu, 27 Aug 2026 09:51:08 -0700 Subject: [PATCH 1/4] test: migrate math/base/special/digamma to ULP-based assertions --- .../@stdlib/math/base/special/digamma/test/test.js | 6 +++--- .../@stdlib/math/base/special/digamma/test/test.native.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js index 949323ed8909..37134f32a826 100644 --- a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js @@ -23,7 +23,7 @@ var tape = require( 'tape' ); var isfinite = require( '@stdlib/math/base/assert/is-finite' ); var isnan = require( '@stdlib/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var digamma = require( './../lib' ); @@ -81,7 +81,7 @@ tape( 'the function evaluates the digamma function', function test( t ) { b2 = isnan( expected[ i ] ); t.strictEqual( b1, b2, 'returned result is ' + ( (b1) ? '' : 'not' ) + ' NaN' ); if ( !b1 ) { - t.ok( abs( actual - expected[ i ] ) < 1.0e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected[ i ] + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected[ i ], 82 ), true, 'returns expected value' ); } } t.end(); @@ -96,6 +96,6 @@ tape( 'the function evaluates the digamma function for `x` such that remainder > expected = -2.863183589156929; actual = digamma( x ); - t.ok( abs( actual - expected ) < 1.0e-14, 'returned result within tolerance' ); + t.strictEqual( isAlmostSameValue( actual, expected, 82 ), true, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js index 0678c837a7f0..a332fd4caf01 100644 --- a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js @@ -24,7 +24,7 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isfinite = require( '@stdlib/math/base/assert/is-finite' ); var isnan = require( '@stdlib/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -90,7 +90,7 @@ tape( 'the function evaluates the digamma function', opts, function test( t ) { b2 = isnan( expected[ i ] ); t.strictEqual( b1, b2, 'returned result is ' + ( (b1) ? '' : 'not' ) + ' NaN' ); if ( !b1 ) { - t.ok( abs( actual - expected[ i ] ) < 1.0e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected[ i ] + '.' ); + t.strictEqual( isAlmostSameValue( actual, expected[ i ], 82 ), true, 'returns expected value' ); } } t.end(); @@ -105,6 +105,6 @@ tape( 'the function evaluates the digamma function for `x` such that remainder > expected = -2.863183589156929; actual = digamma( x ); - t.ok( abs( actual - expected ) < 1.0e-14, 'returned result within tolerance' ); + t.strictEqual( isAlmostSameValue( actual, expected, 82 ), true, 'returns expected value' ); t.end(); }); From d8f434e5880c6ec557734100d71bab3a73e2848f Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 27 Aug 2026 17:02:46 -0700 Subject: [PATCH 2/4] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- lib/node_modules/@stdlib/math/base/special/digamma/test/test.js | 2 +- .../@stdlib/math/base/special/digamma/test/test.native.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js index 37134f32a826..ef6c1f079ce0 100644 --- a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js @@ -39,7 +39,7 @@ for ( i = 0; i < expected.length; i++ ) { if ( v === 'Inf' ) { expected[ i ] = PINF; } - else if ( v === 'NaN' ) { +} else if ( v === 'NaN' ) { expected[ i ] = NaN; } } diff --git a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js index a332fd4caf01..3c411eac8d1e 100644 --- a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js @@ -48,7 +48,7 @@ for ( i = 0; i < expected.length; i++ ) { if ( v === 'Inf' ) { expected[ i ] = PINF; } - else if ( v === 'NaN' ) { +} else if ( v === 'NaN' ) { expected[ i ] = NaN; } } From bdfed205126843ef5c2b60521a05b7e836b5835f Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 27 Aug 2026 17:03:31 -0700 Subject: [PATCH 3/4] test: fix bracket Signed-off-by: Athan --- .../@stdlib/math/base/special/digamma/test/test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js index ef6c1f079ce0..245d3c4b5f28 100644 --- a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.js @@ -38,8 +38,7 @@ for ( i = 0; i < expected.length; i++ ) { v = expected[ i ]; if ( v === 'Inf' ) { expected[ i ] = PINF; - } -} else if ( v === 'NaN' ) { + } else if ( v === 'NaN' ) { expected[ i ] = NaN; } } From c6e4aba846bf7c4eeedc13ced6f5e469821a0a9d Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 27 Aug 2026 17:03:58 -0700 Subject: [PATCH 4/4] test: fix bracket Signed-off-by: Athan --- .../@stdlib/math/base/special/digamma/test/test.native.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js index 3c411eac8d1e..9ec2b5db5d95 100644 --- a/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js @@ -47,8 +47,7 @@ for ( i = 0; i < expected.length; i++ ) { v = expected[ i ]; if ( v === 'Inf' ) { expected[ i ] = PINF; - } -} else if ( v === 'NaN' ) { + } else if ( v === 'NaN' ) { expected[ i ] = NaN; } }