From 305fa983262ed6e5ede8cdbd137268ea66c04fd2 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Wed, 26 Aug 2026 10:29:10 +0000 Subject: [PATCH] test: migrate `stats/base/dists/gumbel/median` to ULP-based assertions Migrate the JavaScript and native test suites from relative tolerance assertions to ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The measured maximum ULP difference across the fixture set is `0` for both the JavaScript and native implementations, so the tests assert a maximum allowed difference of `0` ULP. Resolves a part of #11352. Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01M4tVv8pEgy2wh9DZoqWqFp --- .../stats/base/dists/gumbel/median/test/test.js | 13 ++----------- .../base/dists/gumbel/median/test/test.native.js | 15 +++------------ 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.js index d5705d19063c..db864245a18c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var median = require( './../lib' ); @@ -76,9 +75,7 @@ tape( 'if provided a nonpositive `beta`, the function returns `NaN`', function t tape( 'the function returns the median of a Gumbel distribution', function test( t ) { var expected; - var delta; var beta; - var tol; var mu; var y; var i; @@ -89,13 +86,7 @@ tape( 'the function returns the median of a Gumbel distribution', function test( for ( i = 0; i < mu.length; i++ ) { y = median( mu[i], beta[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.native.js index 682be826b228..023672054a04 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gumbel/median/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -85,9 +84,7 @@ tape( 'if provided a nonpositive `beta`, the function returns `NaN`', opts, func tape( 'the function returns the median of a Gumbel distribution', opts, function test( t ) { var expected; - var delta; var beta; - var tol; var mu; var y; var i; @@ -97,14 +94,8 @@ tape( 'the function returns the median of a Gumbel distribution', opts, function beta = data.beta; for ( i = 0; i < mu.length; i++ ) { y = median( mu[i], beta[i] ); - if ( expected[i] !== null) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + if ( expected[i] !== null ) { + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end();