From d7220674b8b011a81318b0bd07bf362766bbaa24 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 25 Aug 2026 18:18:25 +0000 Subject: [PATCH] test: migrate `stats/base/dists/uniform/quantile` to ULP-based assertions Replace relative tolerance assertions with `isAlmostSameValue` ULP difference assertions in the `stats/base/dists/uniform/quantile` test suite. All fixture values match exactly, so the minimum required ULP bound is `0` for the JavaScript, factory, and native test files. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01NbeWLyp2YBanmPrDdD2hsX --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../uniform/quantile/test/test.factory.js | 33 +++---------------- .../uniform/quantile/test/test.native.js | 33 +++---------------- .../uniform/quantile/test/test.quantile.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.factory.js index 8c5444fe98eb..0cbafa997b18 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -117,8 +116,6 @@ tape( 'if provided `a >= b`, the created function always returns `NaN`', functio tape( 'the created function evaluates the quantile for `p` given a small range `b - a`', function test( t ) { var expected; var quantile; - var delta; - var tol; var a; var b; var i; @@ -132,13 +129,7 @@ tape( 'the created function evaluates the quantile for `p` given a small range ` for ( i = 0; i < p.length; i++ ) { quantile = factory( a[i], b[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -146,8 +137,6 @@ tape( 'the created function evaluates the quantile for `p` given a small range ` tape( 'the created function evaluates the quantile for `p` given a medium range `b - a`', function test( t ) { var expected; var quantile; - var delta; - var tol; var a; var b; var i; @@ -161,13 +150,7 @@ tape( 'the created function evaluates the quantile for `p` given a medium range for ( i = 0; i < p.length; i++ ) { quantile = factory( a[i], b[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -175,8 +158,6 @@ tape( 'the created function evaluates the quantile for `p` given a medium range tape( 'the created function evaluates the quantile for `p` given a large range `b - a`', function test( t ) { var expected; var quantile; - var delta; - var tol; var a; var b; var i; @@ -190,13 +171,7 @@ tape( 'the created function evaluates the quantile for `p` given a large range ` for ( i = 0; i < p.length; i++ ) { quantile = factory( a[i], b[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.native.js index 49014f8dcaba..3457b4db10c5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -91,8 +90,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', opts, function test( t tape( 'the function evaluates the quantile for `p` given a small range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -105,21 +102,13 @@ tape( 'the function evaluates the quantile for `p` given a small range `b - a`', b = smallRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a medium range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -132,21 +121,13 @@ tape( 'the function evaluates the quantile for `p` given a medium range `b - a`' b = mediumRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a large range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -159,13 +140,7 @@ tape( 'the function evaluates the quantile for `p` given a large range `b - a`', b = largeRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.quantile.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.quantile.js index ac1bd0e9ac00..aaac0fefbf9d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.quantile.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/quantile/test/test.quantile.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var quantile = require( './../lib' ); @@ -82,8 +81,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', function test( t ) { tape( 'the function evaluates the quantile for `p` given a small range `b - a`', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -96,21 +93,13 @@ tape( 'the function evaluates the quantile for `p` given a small range `b - a`', b = smallRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a medium range `b - a`', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -123,21 +112,13 @@ tape( 'the function evaluates the quantile for `p` given a medium range `b - a`' b = mediumRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a large range `b - a`', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -150,13 +131,7 @@ tape( 'the function evaluates the quantile for `p` given a large range `b - a`', b = largeRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });