From 806d92b35d2004b34cd5acf3ee0778ec5e24a94e Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 20 Aug 2026 22:19:54 +0000 Subject: [PATCH] test: migrate `math/base/special/logitf` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/logitf/test/test.js | 40 +++++-------------- .../base/special/logitf/test/test.native.js | 40 +++++-------------- 2 files changed, 22 insertions(+), 58 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/test/test.js b/lib/node_modules/@stdlib/math/base/special/logitf/test/test.js index c2f30e4d9fb5..9c342aac9480 100644 --- a/lib/node_modules/@stdlib/math/base/special/logitf/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/logitf/test/test.js @@ -24,8 +24,8 @@ var tape = require( 'tape' ); var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); var PINF = require( '@stdlib/constants/float32/pinf' ); var NINF = require( '@stdlib/constants/float32/ninf' ); -var EPS = require( '@stdlib/constants/float32/eps' ); -var absf = require( '@stdlib/math/base/special/absf' ); +var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' ); +var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' ); var logitf = require( './../lib' ); @@ -72,69 +72,51 @@ tape( 'the function returns `+Infinity` when provided `1`', function test( t ) { tape( 'the function evaluates the logit of `x` for the interval `(0,0.25]`', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = small.expected; x = small.x; for ( i = 0; i < x.length; i++ ) { y = logitf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = absf( y - expected[i] ); - tol = EPS * absf( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + e = float64ToFloat32( expected[i] ); + t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logit of `x` for the interval `[0.25,0.75]`', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = medium.expected; x = medium.x; for ( i = 0; i < x.length; i++ ) { y = logitf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = absf( y - expected[i] ); - tol = EPS * absf( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + e = float64ToFloat32( expected[i] ); + t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logit of `x` for the interval `[0.75,1)`', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = large.expected; x = large.x; for ( i = 0; i < x.length; i++ ) { y = logitf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = absf( y - expected[i] ); - tol = EPS * absf( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + e = float64ToFloat32( expected[i] ); + t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/logitf/test/test.native.js index adc7901af844..19e8eaefa1ef 100644 --- a/lib/node_modules/@stdlib/math/base/special/logitf/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/logitf/test/test.native.js @@ -25,8 +25,8 @@ var tape = require( 'tape' ); var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); var PINF = require( '@stdlib/constants/float32/pinf' ); var NINF = require( '@stdlib/constants/float32/ninf' ); -var EPS = require( '@stdlib/constants/float32/eps' ); -var absf = require( '@stdlib/math/base/special/absf' ); +var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' ); +var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -81,69 +81,51 @@ tape( 'the function returns `+Infinity` when provided `1`', opts, function test( tape( 'the function evaluates the logit of `x` for the interval `(0,0.25]`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = small.expected; x = small.x; for ( i = 0; i < x.length; i++ ) { y = logitf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = absf( y - expected[i] ); - tol = EPS * absf( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + e = float64ToFloat32( expected[i] ); + t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logit of `x` for the interval `[0.25,0.75]`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = medium.expected; x = medium.x; for ( i = 0; i < x.length; i++ ) { y = logitf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = absf( y - expected[i] ); - tol = EPS * absf( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + e = float64ToFloat32( expected[i] ); + t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logit of `x` for the interval `[0.75,1)`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = large.expected; x = large.x; for ( i = 0; i < x.length; i++ ) { y = logitf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = absf( y - expected[i] ); - tol = EPS * absf( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + e = float64ToFloat32( expected[i] ); + t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' ); } t.end(); });