From c52c206445eb5ff8683477b741b070d51e51ac58 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 18 Aug 2026 09:17:54 +0000 Subject: [PATCH] test: migrate `stats/base/dists/negative-binomial/cdf` to ULP-based assertions Resolves a part of #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../negative-binomial/cdf/test/test.cdf.js | 43 +++---------------- .../cdf/test/test.factory.js | 43 +++---------------- 2 files changed, 10 insertions(+), 76 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.cdf.js b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.cdf.js index f1b00caf4959..e28e73836463 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.cdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.cdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var cdf = require( './../lib' ); @@ -113,8 +112,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function evaluates the cdf for `x` given large `r` and `p`', function test( t ) { var expected; - var delta; - var tol; var x; var r; var p; @@ -127,21 +124,13 @@ tape( 'the function evaluates the cdf for `x` given large `r` and `p`', function p = highHigh.p; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 80.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 63 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given large `r` and small `p`', function test( t ) { var expected; - var delta; - var tol; var x; var r; var p; @@ -154,21 +143,13 @@ tape( 'the function evaluates the cdf for `x` given large `r` and small `p`', fu p = highSmall.p; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 320.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 441 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given small `r` and large `p`', function test( t ) { var expected; - var delta; - var tol; var x; var r; var p; @@ -181,21 +162,13 @@ tape( 'the function evaluates the cdf for `x` given small `r` and large `p`', fu p = smallHigh.p; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 10.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 9 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given small `r` and `p`', function test( t ) { var expected; - var delta; - var tol; var x; var r; var p; @@ -208,13 +181,7 @@ tape( 'the function evaluates the cdf for `x` given small `r` and `p`', function p = smallSmall.p; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 80.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 89 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.factory.js index 73e9daf59602..e5ce2c1453ef 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/cdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -161,9 +160,7 @@ tape( 'if provided a success probability `p` outside `[0,1]`, the created functi tape( 'the created function evaluates the cdf for `x` given large `r` and `p`', function test( t ) { var expected; - var delta; var cdf; - var tol; var i; var r; var p; @@ -177,22 +174,14 @@ tape( 'the created function evaluates the cdf for `x` given large `r` and `p`', for ( i = 0; i < x.length; i++ ) { cdf = factory( r[i], p[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 60.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 63 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the cdf for `x` given large `r` and small `p`', function test( t ) { var expected; - var delta; var cdf; - var tol; var i; var p; var r; @@ -206,22 +195,14 @@ tape( 'the created function evaluates the cdf for `x` given large `r` and small for ( i = 0; i < x.length; i++ ) { cdf = factory( r[i], p[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 320.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 441 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the cdf for `x` given small `r` and large `p`', function test( t ) { var expected; - var delta; var cdf; - var tol; var i; var r; var p; @@ -235,22 +216,14 @@ tape( 'the created function evaluates the cdf for `x` given small `r` and large for ( i = 0; i < x.length; i++ ) { cdf = factory( r[i], p[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 10.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 9 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the cdf for `x` given small `r` and `p`', function test( t ) { var expected; - var delta; var cdf; - var tol; var i; var r; var p; @@ -264,13 +237,7 @@ tape( 'the created function evaluates the cdf for `x` given small `r` and `p`', for ( i = 0; i < x.length; i++ ) { cdf = factory( r[i], p[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 80.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 89 ), true, 'returns expected value' ); } t.end(); });