From c907a4464c76d487cb6d6d9fa46a10a1756febc1 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 10 Aug 2026 21:27:49 +0000 Subject: [PATCH] test: migrate `math/base/special/cospi` to ULP-based assertions Replaces relative-tolerance comparisons in the fixture-driven test with `@stdlib/assert/is-almost-same-value`, matching the pattern established for other `math/base/special` packages. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01RXRe7DKMnJDk6MHLbuqWgk --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/math/base/special/cospi/test/test.js | 13 ++----------- .../math/base/special/cospi/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/cospi/test/test.js b/lib/node_modules/@stdlib/math/base/special/cospi/test/test.js index 37ab8dcd7217..d7fa9e88d339 100644 --- a/lib/node_modules/@stdlib/math/base/special/cospi/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/cospi/test/test.js @@ -21,12 +21,11 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var incrspace = require( '@stdlib/array/base/incrspace' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var pow = require( '@stdlib/math/base/special/pow' ); var isPositiveZero = require( '@stdlib/assert/is-positive-zero' ); var cospi = require( './../lib' ); @@ -134,8 +133,6 @@ tape( 'the function is even', function test( t ) { tape( 'the function computes `cos(πx)`', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -144,13 +141,7 @@ tape( 'the function computes `cos(πx)`', function test( t ) { expected = decimals.expected; for ( i = 0; i < x.length; i++ ) { y = cospi( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.0 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/cospi/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/cospi/test/test.native.js index c048e8f82896..3ad0d32ec16a 100644 --- a/lib/node_modules/@stdlib/math/base/special/cospi/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/cospi/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var incrspace = require( '@stdlib/array/base/incrspace' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var pow = require( '@stdlib/math/base/special/pow' ); var isPositiveZero = require( '@stdlib/assert/is-positive-zero' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -143,8 +142,6 @@ tape( 'the function is even', opts, function test( t ) { tape( 'the function computes `cos(πx)`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -153,13 +150,7 @@ tape( 'the function computes `cos(πx)`', opts, function test( t ) { expected = decimals.expected; for ( i = 0; i < x.length; i++ ) { y = cospi( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.0 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });