From 6ebea641161f1128a0422c6fd662619a49b67891 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 7 Aug 2026 02:20:48 +0000 Subject: [PATCH] test: migrate `math/base/special/gamma1pm1` to ULP-based assertions Replaces relative tolerance assertions in the `gamma1pm1` fixture loops with `isAlmostSameValue` ULP-based assertions. The ULP bounds are the measured minimums over the full fixture sets: 3 ULP for the small negative fixtures and 2 ULP for the small positive fixtures, for both the JavaScript and native implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01L8y1oQRpySabKgjBMumaWs --- .../math/base/special/gamma1pm1/test/test.js | 15 +++------------ .../base/special/gamma1pm1/test/test.native.js | 15 +++------------ 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.js b/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.js index 4264cb030265..7712ce1209fa 100644 --- a/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var gamma = require( '@stdlib/math/base/special/gamma' ); -var abs = require( '@stdlib/math/base/special/abs' ); var incrspace = require( '@stdlib/array/base/incrspace' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var gamma1pm1 = require( './../lib' ); @@ -78,8 +77,6 @@ tape( 'the function computes `gamma(x+1) - 1` for most `x` (positive)', function tape( 'the function accurately computes `gamma(x+1) - 1` for small negative numbers', function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -89,17 +86,13 @@ tape( 'the function accurately computes `gamma(x+1) - 1` for small negative numb for ( i = 0; i < x.length; i++ ) { v = gamma1pm1( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 5.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. E: ' + expected[ i ] + '. Δ: ' + delta + '. tol: ' + tol + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 3 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function accurately computes `gamma(x+1) - 1` for small positive numbers', function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -109,9 +102,7 @@ tape( 'the function accurately computes `gamma(x+1) - 1` for small positive numb for ( i = 0; i < x.length; i++ ) { v = gamma1pm1( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. E: ' + expected[ i ] + '. Δ: ' + delta + '. tol: ' + tol + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.native.js index ef017c6f71d2..62d031b35175 100644 --- a/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/gamma1pm1/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var gamma = require( '@stdlib/math/base/special/gamma' ); -var abs = require( '@stdlib/math/base/special/abs' ); var incrspace = require( '@stdlib/array/base/incrspace' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -87,8 +86,6 @@ tape( 'the function computes `gamma(x+1) - 1` for most `x` (positive)', opts, fu tape( 'the function accurately computes `gamma(x+1) - 1` for small negative numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -98,17 +95,13 @@ tape( 'the function accurately computes `gamma(x+1) - 1` for small negative numb for ( i = 0; i < x.length; i++ ) { v = gamma1pm1( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 5.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. E: ' + expected[ i ] + '. Δ: ' + delta + '. tol: ' + tol + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 3 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function accurately computes `gamma(x+1) - 1` for small positive numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -118,9 +111,7 @@ tape( 'the function accurately computes `gamma(x+1) - 1` for small positive numb for ( i = 0; i < x.length; i++ ) { v = gamma1pm1( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. E: ' + expected[ i ] + '. Δ: ' + delta + '. tol: ' + tol + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });