From 000750cd5996437df845ecd74625b9604e80fdb7 Mon Sep 17 00:00:00 2001 From: fiboNacci1163 Date: Thu, 6 Aug 2026 22:50:56 +0600 Subject: [PATCH 1/2] test: migrate `stats/base/dists/arcsine/cdf` to ULP-based testing --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../dists/arcsine/cdf/test/test.factory.js | 35 +++--------------- .../base/dists/arcsine/cdf/test/test.main.js | 35 +++--------------- .../dists/arcsine/cdf/test/test.native.js | 37 +++---------------- 3 files changed, 16 insertions(+), 91 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.factory.js index ef8d7e89edab..f969a58d9a30 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); var factory = require( './../lib/factory.js' ); @@ -132,9 +131,7 @@ tape( 'if provided a `a >= b`, the created function always returns `NaN`', funct tape( 'the created function evaluates the cdf for `x` given a small range `b - a`', function test( t ) { var expected; - var delta; var cdf; - var tol; var a; var b; var i; @@ -148,22 +145,14 @@ tape( 'the created function evaluates the cdf for `x` given a small range `b - a for ( i = 0; i < x.length; i++ ) { cdf = factory( a[i], b[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the cdf for `x` given a medium range `b - a`', function test( t ) { var expected; - var delta; var cdf; - var tol; var a; var b; var i; @@ -177,22 +166,14 @@ tape( 'the created function evaluates the cdf for `x` given a medium range `b - for ( i = 0; i < x.length; i++ ) { cdf = factory( a[i], b[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the cdf for `x` given a large range `b - a`', function test( t ) { var expected; - var delta; var cdf; - var tol; var a; var b; var i; @@ -206,13 +187,7 @@ tape( 'the created function evaluates the cdf for `x` given a large range `b - a for ( i = 0; i < x.length; i++ ) { cdf = factory( a[i], b[i] ); y = cdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js index 67e8e130899b..9aa822548d4a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js +++ b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); var cdf = require( './../lib' ); @@ -86,8 +85,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', function test( t ) { tape( 'the function evaluates the cdf for `x` given a small range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -100,21 +97,13 @@ tape( 'the function evaluates the cdf for `x` given a small range `b - a`', func b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue(y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given a medium range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -127,21 +116,13 @@ tape( 'the function evaluates the cdf for `x` given a medium range `b - a`', fun b = mediumRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given a large range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -154,13 +135,7 @@ tape( 'the function evaluates the cdf for `x` given a large range `b - a`', func b = largeRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'retruns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.native.js index 7a055661a841..43849057be4d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var tryRequire = require( '@stdlib/utils/try-require' ); -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var tryRequire = require( '@stdlib/utils/try-require' ); // FIXTURES // @@ -95,8 +94,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', opts, function test( t tape( 'the function evaluates the cdf for `x` given a small range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -109,21 +106,13 @@ tape( 'the function evaluates the cdf for `x` given a small range `b - a`', opts b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'retruns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given a medium range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -136,21 +125,13 @@ tape( 'the function evaluates the cdf for `x` given a medium range `b - a`', opt b = mediumRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the cdf for `x` given a large range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -163,13 +144,7 @@ tape( 'the function evaluates the cdf for `x` given a large range `b - a`', opts b = largeRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); }); From d0c1ac8e140846d3a21bd3bacafe233608d2724e Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 6 Aug 2026 16:12:19 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js index 9aa822548d4a..d30d6b52a338 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js +++ b/lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js @@ -97,7 +97,7 @@ tape( 'the function evaluates the cdf for `x` given a small range `b - a`', func b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = cdf( x[i], a[i], b[i] ); - t.strictEqual( isAlmostSameValue(y, expected[i], 2 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[i], 2 ), true, 'returns expected value' ); } t.end(); });