From 7a99c80d3cc228fcbf6f5912233fb9aadef8bda9 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 6 Aug 2026 10:24:00 +0000 Subject: [PATCH] test: migrate `math/base/special/expit` to ULP-based assertions Migrate the `math/base/special/expit` tests from relative tolerance (`EPS`-scaled) assertions to ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of `2` for both the JavaScript and native test files. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_014zrHEc6Qt61uPr8oo1zWcM --- .../math/base/special/expit/test/test.js | 25 ++++--------------- .../base/special/expit/test/test.native.js | 25 ++++--------------- 2 files changed, 10 insertions(+), 40 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/expit/test/test.js b/lib/node_modules/@stdlib/math/base/special/expit/test/test.js index 9949d6a5998b..1938569dff7e 100644 --- a/lib/node_modules/@stdlib/math/base/special/expit/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/expit/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var expit = require( './../lib' ); @@ -69,46 +68,32 @@ tape( 'the function returns `0.0` when provided `-Infinity`', function test( t ) tape( 'the function evaluates the standard logistic function for negative numbers', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; expected = negative.expected; x = negative.x; + for ( i = 0; i < x.length; i++ ) { y = expit( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.5 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the standard logistic function for positive numbers', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; expected = positive.expected; x = positive.x; + for ( i = 0; i < x.length; i++ ) { y = expit( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.5 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/expit/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/expit/test/test.native.js index dfba0fbc0ff8..a12fb62ac3b4 100644 --- a/lib/node_modules/@stdlib/math/base/special/expit/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/expit/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var tryRequire = require( '@stdlib/utils/try-require' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); // FIXTURES // @@ -78,46 +77,32 @@ tape( 'the function returns `0.0` when provided `-Infinity`', opts, function tes tape( 'the function evaluates the standard logistic function for negative numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; expected = negative.expected; x = negative.x; + for ( i = 0; i < x.length; i++ ) { y = expit( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.5 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the standard logistic function for positive numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; expected = positive.expected; x = positive.x; + for ( i = 0; i < x.length; i++ ) { y = expit( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.5 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. v: '+y+'. E: '+expected[i]+' Δ: '+delta+'. tol: '+tol ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });