From fffab514e47818893b5e36ff1aa029f6441ccb44 Mon Sep 17 00:00:00 2001 From: Ujjwal Verma Date: Sun, 2 Aug 2026 00:57:05 +0530 Subject: [PATCH] test: migrate math/base/special/spence to ULP-based testing --- .../math/base/special/spence/test/test.js | 23 ++++------------- .../base/special/spence/test/test.native.js | 25 ++++--------------- 2 files changed, 10 insertions(+), 38 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/spence/test/test.js b/lib/node_modules/@stdlib/math/base/special/spence/test/test.js index cbe271e88f3b..e9c672bb6acb 100644 --- a/lib/node_modules/@stdlib/math/base/special/spence/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/spence/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); +var PI_SQUARED = require( '@stdlib/constants/float64/pi-squared' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive; -var abs = require( '@stdlib/math/base/special/abs' ); -var PI_SQUARED = require( '@stdlib/constants/float64/pi-squared' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var spence = require( './../lib' ); @@ -46,8 +45,6 @@ tape( 'main export is a function', function test( t ) { tape( 'the function accurately computes the dilogarithm for small positive numbers', function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -57,17 +54,13 @@ tape( 'the function accurately computes the dilogarithm for small positive numbe for ( i = 0; i < x.length; i++ ) { v = spence( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. actual: ' + v + '. expected: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function accurately computes the dilogarithm for medium positive numbers', function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -77,17 +70,13 @@ tape( 'the function accurately computes the dilogarithm for medium positive numb for ( i = 0; i < x.length; i++ ) { v = spence( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. actual: ' + v + '. expected: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function accurately computes the dilogarithm for large positive numbers', function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -97,9 +86,7 @@ tape( 'the function accurately computes the dilogarithm for large positive numbe for ( i = 0; i < x.length; i++ ) { v = spence( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. actual: ' + v + '. expected: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/spence/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/spence/test/test.native.js index 8f2571e4efba..862c0ccb256e 100644 --- a/lib/node_modules/@stdlib/math/base/special/spence/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/spence/test/test.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PI_SQUARED = require( '@stdlib/constants/float64/pi-squared' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -54,8 +53,6 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function accurately computes the dilogarithm for small positive numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -65,17 +62,13 @@ tape( 'the function accurately computes the dilogarithm for small positive numbe for ( i = 0; i < x.length; i++ ) { v = spence( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. Expected: ' + expected[ i ] + '. Tolerance: ' + tol + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function accurately computes the dilogarithm for medium positive numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -85,19 +78,13 @@ tape( 'the function accurately computes the dilogarithm for medium positive numb for ( i = 0; i < x.length; i++ ) { v = spence( x[ i ] ); - delta = abs( v - expected[ i ] ); - - // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 - tol = 8.3 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. actual: ' + v + '. expected: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function accurately computes the dilogarithm for large positive numbers', opts, function test( t ) { var expected; - var delta; - var tol; var x; var v; var i; @@ -107,9 +94,7 @@ tape( 'the function accurately computes the dilogarithm for large positive numbe for ( i = 0; i < x.length; i++ ) { v = spence( x[ i ] ); - delta = abs( v - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. actual: ' + v + '. expected: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' ); + t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });