From ea9b3fdeede90e253bb52a96e75e39a46486f115 Mon Sep 17 00:00:00 2001 From: Arjan Date: Thu, 30 Jul 2026 16:00:43 +0530 Subject: [PATCH] test: migrate `math/base/special/ellipe` to ULP difference testing --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/ellipe/test/test.js | 39 +++++-------------- .../base/special/ellipe/test/test.native.js | 39 +++++-------------- 2 files changed, 20 insertions(+), 58 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.js b/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.js index 57bb2de23e4d..2ef0f714f0dd 100644 --- a/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.js @@ -22,11 +22,10 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var HALF_PI = require( '@stdlib/constants/float64/half-pi' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var ellipe = require( './../lib' ); @@ -47,70 +46,52 @@ tape( 'main export is a function', function test( t ) { tape( 'the function evaluates the complete elliptic integral of the second kind (medium positive values)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = mediumPositive.expected; x = mediumPositive.x; for ( i = 0; i < x.length; i++ ) { y = ellipe( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 5.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 5 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the complete elliptic integral of the second kind (values close to positive unity)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = closeToUnity.expected; x = closeToUnity.x; for ( i = 0; i < x.length; i++ ) { y = ellipe( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 4.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 4 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the complete elliptic integral of the second kind (spot checked negative values)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; // The spot checked values are derived from Wolfram Alpha and cross-checked against Maxima. For example, to compute E(-0.1): https://www.wolframalpha.com/input/?i=EllipticE(-0.1) expected = negativeSpotChecks.expected; x = negativeSpotChecks.x; for ( i = 0; i < x.length; i++ ) { y = ellipe( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 2.2 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 4 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js index 2ec2d1c3dfb1..b61031e5f087 100644 --- a/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js @@ -23,11 +23,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var HALF_PI = require( '@stdlib/constants/float64/half-pi' ); -var EPS = require( '@stdlib/constants/float64/eps' ); -var abs = require( '@stdlib/math/base/special/abs' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -56,70 +55,52 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function evaluates the complete elliptic integral of the second kind (values close to positive unity)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = closeToUnity.expected; x = closeToUnity.x; for ( i = 0; i < x.length; i++ ) { y = ellipe( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 4.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 4 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the complete elliptic integral of the second kind (medium positive values)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; expected = mediumPositive.expected; x = mediumPositive.x; for ( i = 0; i < x.length; i++ ) { y = ellipe( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 5.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 5 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the complete elliptic integral of the second kind (spot checked negative values)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; + var e; // The spot checked values are derived from Wolfram Alpha and cross-checked against Maxima. For example, to compute E(-0.1): https://www.wolframalpha.com/input/?i=EllipticE(-0.1) expected = negativeSpotChecks.expected; x = negativeSpotChecks.x; for ( i = 0; i < x.length; i++ ) { y = ellipe( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 2.2 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + e = expected[ i ]; + t.strictEqual( isAlmostSameValue( y, e, 4 ), true, 'returns expected value' ); } t.end(); });