Skip to content

Commit df58e94

Browse files
kgrytekgryte
authored
test: migrate stats/base/dists/logistic/quantile to ULP-based assertions
PR-URL: #15221 Reviewed-by: Athan Reines <kgryte@gmail.com> Ref: #11352
1 parent 5d2e5bd commit df58e94

3 files changed

Lines changed: 12 additions & 87 deletions

File tree

‎lib/node_modules/@stdlib/stats/base/dists/logistic/quantile/test/test.factory.js‎

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
2425
var isnan = require( '@stdlib/math/base/assert/is-nan' );
25-
var abs = require( '@stdlib/math/base/special/abs' );
2626
var PINF = require( '@stdlib/constants/float64/pinf' );
2727
var NINF = require( '@stdlib/constants/float64/ninf' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
2928
var factory = require( './../lib/factory.js' );
3029

3130

@@ -146,8 +145,6 @@ tape( 'if `s` equals `0`, the created function evaluates a degenerate distributi
146145
tape( 'the created function evaluates the quantile function at `p` given positive `mu`', function test( t ) {
147146
var expected;
148147
var quantile;
149-
var delta;
150-
var tol;
151148
var mu;
152149
var s;
153150
var p;
@@ -162,13 +159,7 @@ tape( 'the created function evaluates the quantile function at `p` given positiv
162159
quantile = factory( mu[i], s[i] );
163160
y = quantile( p[i] );
164161
if ( expected[i] !== null ) {
165-
if ( y === expected[i] ) {
166-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
167-
} else {
168-
delta = abs( y - expected[ i ] );
169-
tol = 1.0 * EPS * abs( expected[ i ] );
170-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
171-
}
162+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
172163
}
173164
}
174165
t.end();
@@ -177,8 +168,6 @@ tape( 'the created function evaluates the quantile function at `p` given positiv
177168
tape( 'the created function evaluates the quantile function at `p` given negative `mu`', function test( t ) {
178169
var expected;
179170
var quantile;
180-
var delta;
181-
var tol;
182171
var mu;
183172
var s;
184173
var p;
@@ -193,13 +182,7 @@ tape( 'the created function evaluates the quantile function at `p` given negativ
193182
quantile = factory( mu[i], s[i] );
194183
y = quantile( p[i] );
195184
if ( expected[i] !== null ) {
196-
if ( y === expected[i] ) {
197-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
198-
} else {
199-
delta = abs( y - expected[ i ] );
200-
tol = 1.0 * EPS * abs( expected[ i ] );
201-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
202-
}
185+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
203186
}
204187
}
205188
t.end();
@@ -208,8 +191,6 @@ tape( 'the created function evaluates the quantile function at `p` given negativ
208191
tape( 'the created function evaluates the quantile function at `p` given large variance ( = large `s`)', function test( t ) {
209192
var expected;
210193
var quantile;
211-
var delta;
212-
var tol;
213194
var mu;
214195
var s;
215196
var p;
@@ -224,13 +205,7 @@ tape( 'the created function evaluates the quantile function at `p` given large v
224205
quantile = factory( mu[i], s[i] );
225206
y = quantile( p[i] );
226207
if ( expected[i] !== null ) {
227-
if ( y === expected[i] ) {
228-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
229-
} else {
230-
delta = abs( y - expected[ i ] );
231-
tol = 1.0 * EPS * abs( expected[ i ] );
232-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
233-
}
208+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
234209
}
235210
}
236211
t.end();

‎lib/node_modules/@stdlib/stats/base/dists/logistic/quantile/test/test.native.js‎

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,11 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
25+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
2526
var tryRequire = require( '@stdlib/utils/try-require' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
27-
var abs = require( '@stdlib/math/base/special/abs' );
2828
var PINF = require( '@stdlib/constants/float64/pinf' );
2929
var NINF = require( '@stdlib/constants/float64/ninf' );
30-
var EPS = require( '@stdlib/constants/float64/eps' );
3130

3231

3332
// VARIABLES //
@@ -114,8 +113,6 @@ tape( 'if provided `s` equals `0`, the function evaluates a degenerate distribut
114113

115114
tape( 'the function evaluates the quantile function at `p` given positive `mu`', opts, function test( t ) {
116115
var expected;
117-
var delta;
118-
var tol;
119116
var mu;
120117
var p;
121118
var s;
@@ -129,22 +126,14 @@ tape( 'the function evaluates the quantile function at `p` given positive `mu`',
129126
for ( i = 0; i < p.length; i++ ) {
130127
y = quantile( p[i], mu[i], s[i] );
131128
if ( expected[i] !== null ) {
132-
if ( y === expected[i] ) {
133-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
134-
} else {
135-
delta = abs( y - expected[ i ] );
136-
tol = 60.0 * EPS * abs( expected[ i ] );
137-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
138-
}
129+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
139130
}
140131
}
141132
t.end();
142133
});
143134

144135
tape( 'the function evaluates the quantile function at `p` given negative `mu`', opts, function test( t ) {
145136
var expected;
146-
var delta;
147-
var tol;
148137
var mu;
149138
var p;
150139
var s;
@@ -158,22 +147,14 @@ tape( 'the function evaluates the quantile function at `p` given negative `mu`',
158147
for ( i = 0; i < p.length; i++ ) {
159148
y = quantile( p[i], mu[i], s[i] );
160149
if ( expected[i] !== null ) {
161-
if ( y === expected[i] ) {
162-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
163-
} else {
164-
delta = abs( y - expected[ i ] );
165-
tol = 110.0 * EPS * abs( expected[ i ] );
166-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
167-
}
150+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
168151
}
169152
}
170153
t.end();
171154
});
172155

173156
tape( 'the function evaluates the quantile function at `p` given large variance ( = large `s` )', opts, function test( t ) {
174157
var expected;
175-
var delta;
176-
var tol;
177158
var mu;
178159
var p;
179160
var s;
@@ -187,13 +168,7 @@ tape( 'the function evaluates the quantile function at `p` given large variance
187168
for ( i = 0; i < p.length; i++ ) {
188169
y = quantile( p[i], mu[i], s[i] );
189170
if ( expected[i] !== null ) {
190-
if ( y === expected[i] ) {
191-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
192-
} else {
193-
delta = abs( y - expected[ i ] );
194-
tol = 8.0 * EPS * abs( expected[ i ] );
195-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
196-
}
171+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
197172
}
198173
}
199174
t.end();

‎lib/node_modules/@stdlib/stats/base/dists/logistic/quantile/test/test.quantile.js‎

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24+
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
2425
var isnan = require( '@stdlib/math/base/assert/is-nan' );
25-
var abs = require( '@stdlib/math/base/special/abs' );
2626
var PINF = require( '@stdlib/constants/float64/pinf' );
2727
var NINF = require( '@stdlib/constants/float64/ninf' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
2928
var quantile = require( './../lib' );
3029

3130

@@ -106,8 +105,6 @@ tape( 'if provided `s` equals `0`, the function evaluates a degenerate distribut
106105

107106
tape( 'the function evaluates the quantile function at `p` given positive `mu`', function test( t ) {
108107
var expected;
109-
var delta;
110-
var tol;
111108
var mu;
112109
var p;
113110
var s;
@@ -121,22 +118,14 @@ tape( 'the function evaluates the quantile function at `p` given positive `mu`',
121118
for ( i = 0; i < p.length; i++ ) {
122119
y = quantile( p[i], mu[i], s[i] );
123120
if ( expected[i] !== null ) {
124-
if ( y === expected[i] ) {
125-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
126-
} else {
127-
delta = abs( y - expected[ i ] );
128-
tol = 1.0 * EPS * abs( expected[ i ] );
129-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
130-
}
121+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
131122
}
132123
}
133124
t.end();
134125
});
135126

136127
tape( 'the function evaluates the quantile function at `p` given negative `mu`', function test( t ) {
137128
var expected;
138-
var delta;
139-
var tol;
140129
var mu;
141130
var p;
142131
var s;
@@ -150,22 +139,14 @@ tape( 'the function evaluates the quantile function at `p` given negative `mu`',
150139
for ( i = 0; i < p.length; i++ ) {
151140
y = quantile( p[i], mu[i], s[i] );
152141
if ( expected[i] !== null ) {
153-
if ( y === expected[i] ) {
154-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
155-
} else {
156-
delta = abs( y - expected[ i ] );
157-
tol = 1.0 * EPS * abs( expected[ i ] );
158-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
159-
}
142+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
160143
}
161144
}
162145
t.end();
163146
});
164147

165148
tape( 'the function evaluates the quantile function at `p` given large variance ( = large `s` )', function test( t ) {
166149
var expected;
167-
var delta;
168-
var tol;
169150
var mu;
170151
var p;
171152
var s;
@@ -179,13 +160,7 @@ tape( 'the function evaluates the quantile function at `p` given large variance
179160
for ( i = 0; i < p.length; i++ ) {
180161
y = quantile( p[i], mu[i], s[i] );
181162
if ( expected[i] !== null ) {
182-
if ( y === expected[i] ) {
183-
t.strictEqual( y, expected[i], 'p: '+p[i]+', mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] );
184-
} else {
185-
delta = abs( y - expected[ i ] );
186-
tol = 1.0 * EPS * abs( expected[ i ] );
187-
t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
188-
}
163+
t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );
189164
}
190165
}
191166
t.end();

0 commit comments

Comments
 (0)