Skip to content
This repository was archived by the owner on Aug 12, 2024. It is now read-only.

Commit d909a0b

Browse files
authored
Bug fix: Add default implementation of resolveAsync to make the interface backwards compatible (#53)
1 parent 7925465 commit d909a0b

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

pom.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@
313313
<dependency>
314314
<groupId>com.spotify</groupId>
315315
<artifactId>${project.artifactId}</artifactId>
316-
<version>3.0.2</version>
316+
<version>3.3.0</version>
317317
</dependency>
318318
</oldVersion>
319319
<newVersion>
@@ -322,6 +322,14 @@
322322
</file>
323323
</newVersion>
324324
<parameter>
325+
<overrideCompatibilityChangeParameters>
326+
<overrideCompatibilityChangeParameter>
327+
<compatibilityChange>METHOD_ABSTRACT_NOW_DEFAULT</compatibilityChange>
328+
<binaryCompatible>true</binaryCompatible>
329+
<sourceCompatible>true</sourceCompatible>
330+
<semanticVersionLevel>PATCH</semanticVersionLevel>
331+
</overrideCompatibilityChangeParameter>
332+
</overrideCompatibilityChangeParameters>
325333
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
326334
<onlyBinaryIncompatible>true</onlyBinaryIncompatible>
327335
</parameter>

src/main/java/com/spotify/dns/DnsSrvResolver.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,7 @@ public interface DnsSrvResolver {
4545
* @return a possibly empty list of matching records
4646
* @throws DnsException if there was an error doing the DNS lookup
4747
*/
48-
CompletionStage<List<LookupResult>> resolveAsync(String fqdn);
48+
default CompletionStage<List<LookupResult>> resolveAsync(String fqdn) {
49+
throw new java.lang.UnsupportedOperationException("Not implemented");
50+
}
4951
}

0 commit comments

Comments
 (0)