polishing

Author: chillaq

lib/splitclient-rb/engine/auth_api_client.rb

@@ -21,7 +21,9 @@ def authenticate(api_key)
         return process_error(response) if response.status >= 400 && response.status < 500
 
         @telemetry_runtime_producer.record_sync_error(Telemetry::Domain::Constants::TOKEN_SYNC, response.status.to_i)
-        @config.logger.debug("Error connecting to: #{@config.auth_service_url}. Response status: #{response.status}") if @config.debug_enabled
+        if @config.debug_enabled
+          @config.logger.debug("Error connecting to: #{@config.auth_service_url}. Response status: #{response.status}")
+        end
         { push_enabled: false, retry: true }
       rescue StandardError => e
         @config.logger.debug("AuthApiClient error: #{e.inspect}.") if @config.debug_enabled
@@ -51,7 +53,9 @@ def decode_token(token)
       end
 
       def process_error(response)
-        @config.logger.debug("Error connecting to: #{@config.auth_service_url}. Response status: #{response.status}") if @config.debug_enabled
+        if @config.debug_enabled
+          @config.logger.debug("Error connecting to: #{@config.auth_service_url}. Response status: #{response.status}")
+        end
         @telemetry_runtime_producer.record_auth_rejections if response.status == 401
 
         { push_enabled: false, retry: false }

lib/splitclient-rb/engine/sync_manager.rb

@@ -47,13 +47,13 @@ def start_thread
           connected = false
 
           if @config.streaming_enabled
-            @config.logger.debug('Starting Streaming mode ...') if @config.debug_enabled
+            log_if_debug('Starting Streaming mode ...')
             start_push_status_monitor
             connected = @push_manager.start_sse
           end
 
           unless connected
-            @config.logger.debug('Starting Polling mode ...') if @config.debug_enabled
+            log_if_debug('Starting Polling mode ...')
             @synchronizer.start_periodic_fetch
             record_telemetry(Telemetry::Domain::Constants::SYNC_MODE, SYNC_MODE_POLLING)
           end
@@ -92,7 +92,7 @@ def process_push_shutdown
 
       def process_connected
         if @sse_connected.value
-          @config.logger.debug('Streaming already connected.') if @config.debug_enabled
+          log_if_debug('Streaming already connected.')
           return
         end
 
@@ -107,7 +107,7 @@ def process_connected
 
       def process_forced_stop
         unless @sse_connected.value
-          @config.logger.debug('Streaming already disconnected.') if @config.debug_enabled
+          log_if_debug('Streaming already disconnected.')
           return
         end
 
@@ -120,7 +120,7 @@ def process_forced_stop
 
       def process_disconnect(reconnect)
         unless @sse_connected.value
-          @config.logger.debug('Streaming already disconnected.') if @config.debug_enabled
+          log_if_debug('Streaming already disconnected.')
           return
         end
 
@@ -144,14 +144,14 @@ def record_telemetry(type, data)
 
       def start_push_status_monitor
         @config.threads[:push_status_handler] = Thread.new do
-          @config.logger.debug('Starting push status handler ...') if @config.debug_enabled
+          log_if_debug('Starting push status handler ...')
           incoming_push_status_handler
         end
       end
 
       def incoming_push_status_handler
         while (status = @status_queue.pop)
-          @config.logger.debug("Push status handler dequeue #{status}") if @config.debug_enabled
+          log_if_debug("Push status handler dequeue #{status}")
 
           case status
           when Constants::PUSH_CONNECTED
@@ -169,12 +169,16 @@ def incoming_push_status_handler
           when Constants::PUSH_SUBSYSTEM_OFF
             process_push_shutdown
           else
-            @config.logger.debug('Incorrect push status type.') if @config.debug_enabled
+            log_if_debug('Incorrect push status type.')
           end
         end
       rescue StandardError => e
         @config.logger.error("Push status handler error: #{e.inspect}")
       end
     end
+
+    def log_if_debug(msg)
+      @config.logger.debug(msg) if @config.debug_enabled
+    end
   end
 end

lib/splitclient-rb/sse/workers/splits_worker.rb

@@ -52,7 +52,9 @@ def perform_thread
 
         def perform
           while (notification = @queue.pop)
-            @config.logger.debug("feature_flags_worker change_number dequeue #{notification.data['changeNumber']}") if @config.debug_enabled
+            if @config.debug_enabled
+              @config.logger.debug("feature_flags_worker change_number dequeue #{notification.data['changeNumber']}")
+            end
             case notification.data['type']
             when SSE::EventSource::EventTypes::SPLIT_UPDATE
               success = update_feature_flag(notification)
@@ -117,7 +119,9 @@ def update_rule_based_segment(notification)
         def kill_feature_flag(notification)
           return if @feature_flags_repository.get_change_number.to_i > notification.data['changeNumber']
 
-          @config.logger.debug("feature_flags_worker kill #{notification.data['splitName']}, #{notification.data['changeNumber']}") if @config.debug_enabled
+          if @config.debug_enabled
+            @config.logger.debug("feature_flags_worker kill #{notification.data['splitName']}, #{notification.data['changeNumber']}")
+          end
           @feature_flags_repository.kill(notification.data['changeNumber'],
                                          notification.data['splitName'],
                                          notification.data['defaultTreatment'])