Update ioredis peer dependency to support v5 and fix type compatibility issues

Author: EmilianoSanchez

package-lock.json

@@ -45,11 +45,10 @@
   "bugs": "https://github.com/splitio/javascript-commons/issues",
   "homepage": "https://github.com/splitio/javascript-commons#readme",
   "dependencies": {
-    "@types/ioredis": "^4.28.0",
     "tslib": "^2.3.1"
   },
   "peerDependencies": {
-    "ioredis": "^4.28.0"
+    "ioredis": "^4.28.0 || ^5.0.0"
   },
   "peerDependenciesMeta": {
     "ioredis": {
@@ -68,7 +67,7 @@
     "eslint-plugin-import": "^2.25.3",
     "eslint-plugin-tsdoc": "^0.3.0",
     "fetch-mock": "^9.11.0",
-    "ioredis": "^4.28.0",
+    "ioredis": "^5.0.0",
     "jest": "^27.2.3",
     "jest-localstorage-mock": "^2.4.3",
     "lodash": "^4.17.21",

package.json

@@ -34,7 +34,7 @@ export class ImpressionCountsCacheInRedis extends ImpressionCountsCacheInMemory
     return pipeline.exec()
       .then(data => {
         // If this is the creation of the key on Redis, set the expiration for it in 3600 seconds.
-        if (data.length && data.length === keys.length) {
+        if (data && data.length && data.length === keys.length) {
           return this.redis.expire(this.key, TTL_REFRESH);
         }
       })

src/storages/inRedis/ImpressionCountsCacheInRedis.ts

@@ -25,7 +25,7 @@ export class ImpressionsCacheInRedis implements IImpressionsCacheAsync {
   track(impressions: SplitIO.ImpressionDTO[]): Promise<void> { // @ts-ignore
     return this.redis.rpush(
       this.key,
-      impressionsToJSON(impressions, this.metadata),
+      ...impressionsToJSON(impressions, this.metadata),
     ).then(queuedCount => {
       // If this is the creation of the key on Redis, set the expiration for it in 1hr.
       if (queuedCount === impressions.length) {

src/storages/inRedis/ImpressionsCacheInRedis.ts

@@ -42,6 +42,7 @@ export class RedisAdapter extends ioredis {
   constructor(log: ILogger, storageSettings: Record<string, any> = {}) {
     const options = RedisAdapter._defineOptions(storageSettings);
     // Call the ioredis constructor
+    // @ts-ignore
     super(...RedisAdapter._defineLibrarySettings(options));
 
     this.log = log;

src/storages/inRedis/RedisAdapter.ts

@@ -10,11 +10,11 @@ import type { RedisAdapter } from './RedisAdapter';
 /**
  * Discard errors for an answer of multiple operations.
  */
-function processPipelineAnswer(results: Array<[Error | null, string]>): string[] {
-  return results.reduce((accum: string[], errValuePair: [Error | null, string]) => {
-    if (errValuePair[0] === null) accum.push(errValuePair[1]);
+function processPipelineAnswer(results: Array<[Error | null, unknown]> | null): string[] {
+  return results ? results.reduce((accum: string[], errValuePair: [Error | null, unknown]) => {
+    if (errValuePair[0] === null) accum.push(errValuePair[1] as string);
     return accum;
-  }, []);
+  }, []) : [];
 }
 
 /**
@@ -26,7 +26,7 @@ export class SplitsCacheInRedis extends AbstractSplitsCacheAsync {
   private readonly log: ILogger;
   private readonly redis: RedisAdapter;
   private readonly keys: KeyBuilderSS;
-  private redisError?: string;
+  private redisError?: Error;
   private readonly flagSetsFilter: string[];
 
   constructor(log: ILogger, keys: KeyBuilderSS, redis: RedisAdapter, splitFiltersValidation?: ISplitFiltersValidation) {
@@ -198,11 +198,11 @@ export class SplitsCacheInRedis extends AbstractSplitsCacheAsync {
   */
   getNamesByFlagSets(flagSets: string[]): Promise<Set<string>[]> {
     return this.redis.pipeline(flagSets.map(flagSet => ['smembers', this.keys.buildFlagSetKey(flagSet)])).exec()
-      .then((results) => results.map(([e, value], index) => {
-        if (e === null) return value;
+      .then((results) => results ? results.map(([e, value], index) => {
+        if (e === null) return value as string;
 
         this.log.error(LOG_PREFIX + `Could not read result from get members of flag set ${flagSets[index]} due to an error: ${e}`);
-      }))
+      }) : [])
       .then(namesByFlagSets => namesByFlagSets.map(namesByFlagSet => new Set(namesByFlagSet)));
   }
 

src/storages/inRedis/SplitsCacheInRedis.ts

@@ -38,7 +38,7 @@ export class UniqueKeysCacheInRedis extends UniqueKeysCacheInMemory implements I
     });
 
     this.clear();
-    return this.redis.rpush(this.key, uniqueKeysArray)
+    return this.redis.rpush(this.key, ...uniqueKeysArray)
       .then(data => {
         // If this is the creation of the key on Redis, set the expiration for it in 3600 seconds.
         if (data === featureNames.length) {