Fixes

Author: EmilianoSanchez

src/__tests__/browserSuites/push-fallback.spec.js

@@ -287,12 +287,12 @@ export function testFallback(fetchMock, assert) {
   // Periodic fetch due to polling (memberships is not fetched due to smart pausing)
   fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=1457552649999'), function () {
     const lapse = Date.now() - start;
-    assert.true(nearlyEqual(lapse, MILLIS_STREAMING_DISABLED_CONTROL + settings.scheduler.featuresRefreshRate, 100), 'fetch due to fourth fallback to polling');
+    assert.true(nearlyEqual(lapse, MILLIS_STREAMING_DISABLED_CONTROL + settings.scheduler.featuresRefreshRate), 'fetch due to fourth fallback to polling');
     return { status: 200, body: splitChangesMock3 };
   });
   fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=1457552669999'), function () {
     const lapse = Date.now() - start;
-    assert.true(nearlyEqual(lapse, MILLIS_STREAMING_DISABLED_CONTROL + settings.scheduler.featuresRefreshRate * 2, 100), 'fetch due to fourth fallback to polling');
+    assert.true(nearlyEqual(lapse, MILLIS_STREAMING_DISABLED_CONTROL + settings.scheduler.featuresRefreshRate * 2), 'fetch due to fourth fallback to polling');
     return { status: 200, body: { splits: [], since: 1457552669999, till: 1457552669999 } };
   });
 

src/__tests__/offline/browser.spec.js

@@ -112,6 +112,8 @@ tape('Browser offline mode', function (assert) {
     });
 
     const sdkReadyFromCache = (client) => () => {
+      assert.equal(factory.settings.storage.type, 'MEMORY', 'In localhost mode, storage must fallback to memory storage');
+
       const clientStatus = client.__getStatus();
       assert.equal(clientStatus.isReadyFromCache, true, 'If ready from cache, READY_FROM_CACHE status must be true');
       assert.equal(clientStatus.isReady, false, 'READY status must not be set before READY_FROM_CACHE');

src/settings/storage/browser.js

@@ -1,29 +1,43 @@
 import { isLocalStorageAvailable } from '@splitsoftware/splitio-commons/src/utils/env/isLocalStorageAvailable';
-import { STORAGE_MEMORY } from '@splitsoftware/splitio-commons/src/utils/constants';
+import { LOCALHOST_MODE, STORAGE_MEMORY } from '@splitsoftware/splitio-commons/src/utils/constants';
 
 const STORAGE_LOCALSTORAGE = 'LOCALSTORAGE';
 
 export function validateStorage(settings) {
   let {
     log,
+    mode,
     storage: {
       type,
       options = {},
       prefix
     } = { type: STORAGE_MEMORY },
   } = settings;
+  let __originalType;
+
+  const fallbackToMemory = () => {
+    __originalType = type;
+    type = STORAGE_MEMORY;
+  };
+
+  // In localhost mode, fallback to Memory storage and track original type to emit SDK_READY_FROM_CACHE if corresponds.
+  // ATM, other mode settings (e.g., 'consumer') are ignored in client-side API, and so treated as standalone.
+  if (mode === LOCALHOST_MODE && type === STORAGE_LOCALSTORAGE) {
+    fallbackToMemory();
+  }
 
   // If an invalid storage type is provided OR we want to use LOCALSTORAGE and
   // it's not available, fallback into MEMORY
   if (type !== STORAGE_MEMORY && type !== STORAGE_LOCALSTORAGE ||
     type === STORAGE_LOCALSTORAGE && !isLocalStorageAvailable()) {
-    type = STORAGE_MEMORY;
+    fallbackToMemory();
     log.error('Invalid or unavailable storage. Fallback into MEMORY storage');
   }
 
   return {
     type,
     options,
     prefix,
+    __originalType
   };
 }

types/splitio.d.ts

@@ -1261,18 +1261,6 @@ declare namespace SplitIO {
      * @returns {IManager} The manager instance.
      */
     manager(): IManager,
-    /**
-     * Returns a manager instance of the SDK to explore available information.
-     * @function manager
-     * @returns {IManager} The manager instance.
-     */
-    manager(): IManager,
-    /**
-     * Returns a manager instance of the SDK to explore available information.
-     * @function manager
-     * @returns {IManager} The manager instance.
-     */
-    manager(): IManager,
     /**
      * User consent API.
      * @property UserConsent