Skip to content

Commit fe6fd77

Browse files
rollback ci-cd and fix type definitions
1 parent 688ab58 commit fe6fd77

3 files changed

Lines changed: 5 additions & 31 deletions

File tree

.github/workflows/ci-cd.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build
4848

4949
- name: Store assets
50-
if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/SDKS-8407_baseline' || github.ref == 'refs/heads/main') }}
50+
if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/main') }}
5151
uses: actions/upload-artifact@v3
5252
with:
5353
name: assets
@@ -58,7 +58,7 @@ jobs:
5858
name: Upload assets
5959
runs-on: ubuntu-20.04
6060
needs: build
61-
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/SDKS-8407_baseline' }}
61+
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/development' }}
6262
strategy:
6363
matrix:
6464
environment:

ts-tests/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ const instantiatedSettingsCore: {
200200
} = SDK.settings.core;
201201
// const instantiatedSettingsMode: ('standalone' | 'consumer') = SDK.settings.mode;
202202
const instantiatedSettingsScheduler: { [key: string]: number } = SDK.settings.scheduler;
203-
const instantiatedSettingsStartup: { [key: string]: number | boolean } = SDK.settings.startup;
203+
const instantiatedSettingsStartup: { [key: string]: number } = SDK.settings.startup;
204204
const instantiatedStorage: SplitIO.StorageSync = SDK.settings.storage;
205205
const instantiatedSettingsUrls: { [key: string]: string } = SDK.settings.urls;
206206
const instantiatedSettingsVersion: string = SDK.settings.version;
@@ -561,7 +561,6 @@ let fullBrowserSettings: SplitIO.IBrowserSettings = {
561561
impressionsQueueSize: 1,
562562
telemetryRefreshRate: 1,
563563
segmentsRefreshRate: 1,
564-
largeSegmentsRefreshRate: 1,
565564
offlineRefreshRate: 1,
566565
eventsPushRate: 1,
567566
eventsQueueSize: 1,
@@ -571,8 +570,7 @@ let fullBrowserSettings: SplitIO.IBrowserSettings = {
571570
readyTimeout: 1,
572571
requestTimeoutBeforeReady: 1,
573572
retriesOnFailureBeforeReady: 1,
574-
eventsFirstPushWindow: 1,
575-
waitForLargeSegments: true,
573+
eventsFirstPushWindow: 1
576574
},
577575
urls: {
578576
sdk: 'https://asd.com/sdk',

types/splitio.d.ts

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ interface ISettings {
6161
impressionsQueueSize: number,
6262
telemetryRefreshRate: number,
6363
segmentsRefreshRate: number,
64-
largeSegmentsRefreshRate: number,
6564
offlineRefreshRate: number,
6665
eventsPushRate: number,
6766
eventsQueueSize: number,
@@ -71,8 +70,7 @@ interface ISettings {
7170
readyTimeout: number,
7271
requestTimeoutBeforeReady: number,
7372
retriesOnFailureBeforeReady: number,
74-
eventsFirstPushWindow: number,
75-
waitForLargeSegments: boolean
73+
eventsFirstPushWindow: number
7674
},
7775
readonly storage?: SplitIO.StorageSyncFactory | SplitIO.StorageAsyncFactory,
7876
readonly urls: {
@@ -1007,13 +1005,6 @@ declare namespace SplitIO {
10071005
* @default 10
10081006
*/
10091007
eventsFirstPushWindow?: number,
1010-
/**
1011-
* Whether the SDK should wait for large segments to be ready before emitting SDK_READY event.
1012-
* It only applies if largeSegmentsEnabled is true.
1013-
* @property {boolean} waitForLargeSegments
1014-
* @default true
1015-
*/
1016-
waitForLargeSegments?: boolean
10171008
},
10181009
/**
10191010
* SDK scheduler settings.
@@ -1051,13 +1042,6 @@ declare namespace SplitIO {
10511042
* @default 60
10521043
*/
10531044
segmentsRefreshRate?: number,
1054-
/**
1055-
* The SDK polls Split servers for changes to large segment definitions. This parameter controls this polling period in seconds.
1056-
* It only applies if largeSegmentsEnabled is true.
1057-
* @property {number} largeSegmentsRefreshRate
1058-
* @default 60
1059-
*/
1060-
largeSegmentsRefreshRate?: number,
10611045
/**
10621046
* The SDK posts the queued events data in bulks. This parameter controls the posting rate in seconds.
10631047
* @property {number} eventsPushRate
@@ -1085,14 +1069,6 @@ declare namespace SplitIO {
10851069
* @default 1
10861070
*/
10871071
pushRetryBackoffBase?: number,
1088-
},
1089-
sync?: ISharedSettings['sync'] & {
1090-
/**
1091-
* Enables synchronization of large segments.
1092-
* @property {boolean} largeSegmentsEnabled
1093-
* @default false
1094-
*/
1095-
largeSegmentsEnabled?: boolean
10961072
}
10971073
}
10981074
/**

0 commit comments

Comments
 (0)