Skip to content

Commit e1460fb

Browse files
update ci-cd to simplify CDN RC deployment
1 parent af8f2db commit e1460fb

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

.github/workflows/ci-cd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
run: npm run test
4545

4646
- name: npm build
47-
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
47+
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build
4848

4949
- name: Store assets
5050
if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/development' || github.ref == 'refs/heads/main') }}

.github/workflows/sonar-scan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
run: npm run check
3333

3434
- name: npm Build
35-
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
35+
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build
3636

3737
- name: SonarQube Scan (Push)
3838
if: github.event_name == 'push'

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"build:esm": "rimraf esm && tsc -outDir esm && ./scripts/build_esm_replace_imports.sh",
2727
"build:cjs": "rimraf cjs && tsc -outDir cjs -m CommonJS && ./scripts/build_cjs_replace_imports.sh",
2828
"build:umd-visualizer": "rollup --config rollup.visualizer.config.js",
29-
"build:umd": "rollup --config rollup.ci.config.js --branch=$BUILD_BRANCH --commit_hash=$BUILD_COMMIT",
29+
"build:umd": "rollup --config rollup.ci.config.js --branch=$BUILD_BRANCH",
3030
"build:ga-to-split-autorequire": "terser ./node_modules/@splitsoftware/splitio-commons/src/integrations/ga/autoRequire.js --mangle --output ./scripts/ga-to-split-autorequire.js",
3131
"test": "npm run test:unit && npm run test:e2e",
3232
"test:unit": "jest",

rollup.ci.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import terser from '@rollup/plugin-terser';
33

44
export default env => {
55

6-
const fileName = (outputSuffix) => `split-browser-${env.branch !== 'main' ? `dev-${env.commit_hash || VERSION}` : VERSION}${outputSuffix ? `.${outputSuffix}` : ''}`;
6+
const fileName = (outputSuffix) => `split-browser-${env.branch !== 'main' ? `dev-${VERSION}` : VERSION}${outputSuffix ? `.${outputSuffix}` : ''}`;
77

88
const createRollupConfig = (input, outputSuffix) => ({
99
input,

types/splitio.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ interface ILoggerAPI {
137137
*/
138138
interface IUserConsentAPI {
139139
/**
140-
* Set or update the user consent status. Possible values are `true` and `false`, which represent user consent `'GRANTED'` and `'DECLINED'` respectively.
140+
* Sets or updates the user consent status. Possible values are `true` and `false`, which represent user consent `'GRANTED'` and `'DECLINED'` respectively.
141141
* - `true ('GRANTED')`: the user has granted consent for tracking events and impressions. The SDK will send them to Split cloud.
142142
* - `false ('DECLINED')`: the user has declined consent for tracking events and impressions. The SDK will not send them to Split cloud.
143143
*
@@ -149,7 +149,7 @@ interface IUserConsentAPI {
149149
*/
150150
setStatus(userConsent: boolean): boolean;
151151
/**
152-
* Get the user consent status.
152+
* Gets the user consent status.
153153
*
154154
* @function getStatus
155155
* @returns {ConsentStatus} The user consent status.

0 commit comments

Comments
 (0)