Skip to content

Commit b40d1ce

Browse files
Putting back TypeScript SplitIO namespace at to allow explicit imports of types
1 parent 576ef3a commit b40d1ce

4 files changed

Lines changed: 15 additions & 2 deletions

File tree

ts-tests/index.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
* @author Nico Zelaya <nicolas.zelaya@split.io>
1212
*/
1313

14+
import type * as SplitTypes from '../types/splitio';
15+
1416
import { SplitFactory as SplitFactoryFull, InLocalStorage as InLocalStorageFull, DebugLogger as DebugLoggerFull, InfoLogger as InfoLoggerFull, WarnLogger as WarnLoggerFull, ErrorLogger as ErrorLoggerFull, PluggableStorage as PluggableStorageFull } from '../types/full';
1517
import { SplitFactory, InLocalStorage, DebugLogger, InfoLogger, WarnLogger, ErrorLogger, PluggableStorage } from '../types/index';
1618

@@ -19,6 +21,11 @@ let splitFactory = SplitFactory; splitFactory = SplitFactoryFull;
1921
let inLocalStorage = InLocalStorage; inLocalStorage = InLocalStorageFull;
2022
let pluggableStorage = PluggableStorage; pluggableStorage = PluggableStorageFull;
2123

24+
// Validate that the SplitIO namespace is available and matches the types when imported explicitly
25+
let ambientType: SplitIO.ISDK;
26+
let importedType: SplitTypes.ISDK;
27+
ambientType = importedType;
28+
2229
let stringPromise: Promise<string>;
2330
let splitNamesPromise: Promise<SplitIO.SplitNames>;
2431
let splitViewPromise: Promise<SplitIO.SplitView>;

types/full/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Project: http://www.split.io/
33
// Definitions by: Nico Zelaya <https://github.com/NicoZelaya/>
44

5-
import '@splitsoftware/splitio-commons';
5+
/// <reference path="../splitio.d.ts" />
66

77
export = JsSdk;
88

types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Project: http://www.split.io/
33
// Definitions by: Nico Zelaya <https://github.com/NicoZelaya/>
44

5-
import '@splitsoftware/splitio-commons';
5+
/// <reference path="./splitio.d.ts" />
66

77
export = JsSdk;
88

types/splitio.d.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Type definitions for JavaScript Browser Split Software SDK
2+
3+
import '@splitsoftware/splitio-commons';
4+
5+
export as namespace SplitIO;
6+
export = SplitIO;

0 commit comments

Comments
 (0)