Skip to content

Commit 7cc83ff

Browse files
Refactors for LS
1 parent 3a8d020 commit 7cc83ff

63 files changed

Lines changed: 632 additions & 613 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGES.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
0.16.0 (September XX, 2024)
2+
- Added `factory.destroy()` method, which invokes the `destroy` method on all SDK clients created by the factory.
3+
- Updated @splitsoftware/splitio-commons package to version 1.18.0 that includes minor updates:
4+
- Added support for targeting rules based on large segments for browsers.
5+
- Updated some transitive dependencies for vulnerability fixes.
6+
17
0.15.0 (September 13, 2024)
28
- Updated @splitsoftware/splitio-commons package to version 1.17.0 that includes minor updates:
39
- Added `sync.requestOptions.getHeaderOverrides` configuration option to enhance SDK HTTP request Headers for Authorization Frameworks.

package-lock.json

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@splitsoftware/splitio-browserjs",
3-
"version": "0.15.0",
3+
"version": "0.15.1-rc.0",
44
"description": "Split SDK for JavaScript on Browser",
55
"main": "cjs/index.js",
66
"module": "esm/index.js",
@@ -64,7 +64,7 @@
6464
"bugs": "https://github.com/splitio/javascript-browser-client/issues",
6565
"homepage": "https://github.com/splitio/javascript-browser-client#readme",
6666
"dependencies": {
67-
"@splitsoftware/splitio-commons": "1.17.0",
67+
"@splitsoftware/splitio-commons": "1.17.1-rc.1",
6868
"@types/google.analytics": "0.0.40",
6969
"tslib": "^2.3.1",
7070
"unfetch": "^4.2.0"

src/__tests__/browserSuites/evaluations.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ export default function (config, fetchMock, assert) {
365365
for (i; i < SDK_INSTANCES_TO_TEST; i++) {
366366
let splitio = SplitFactory(config);
367367

368-
fetchMock.getOnce('https://sdk.split.io/api/mySegments/aaaaaaklmnbv', { status: 200, body: { mySegments: [] } });
368+
fetchMock.getOnce('https://sdk.split.io/api/memberships/aaaaaaklmnbv', { status: 200, body: { ms: {} } });
369369

370370
// on TA tests, this is going to return one against the mocked seed.
371371
let clientTABucket1 = splitio.client('aaaaaaklmnbv');

src/__tests__/browserSuites/fetch-specific-splits.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export default function fetchSpecificSplits(fetchMock, assert) {
3232
});
3333
return { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } };
3434
});
35-
fetchMock.get(urls.sdk + '/mySegments/nicolas%40split.io', { status: 200, body: { 'mySegments': [] } });
35+
fetchMock.get(urls.sdk + '/memberships/nicolas%40split.io', { status: 200, body: { 'ms': {} } });
3636

3737
factory = SplitFactory(config);
3838

src/__tests__/browserSuites/ignore-ip-addresses-setting.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export default function (fetchMock, assert) {
103103
const settings = settingsFactory(config);
104104
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
105105
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: { splits: [], since: 1457552620999, till: 1457552620999 } });
106-
fetchMock.getOnce(url(settings, `/mySegments/${encodeURIComponent(config.core.key)}`), { status: 200, body: { mySegments: [] } });
106+
fetchMock.getOnce(url(settings, `/memberships/${encodeURIComponent(config.core.key)}`), { status: 200, body: { ms: {} } });
107107

108108
// Init Split client
109109
const splitio = SplitFactory(config);

src/__tests__/browserSuites/impressions.debug.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { SplitFactory } from '../../';
22
import { settingsFactory } from '../../settings';
33
import splitChangesMock1 from '../mocks/splitchanges.since.-1.json';
44
import splitChangesMock2 from '../mocks/splitchanges.since.1457552620999.json';
5-
import mySegmentsFacundo from '../mocks/mysegments.facundo@split.io.json';
5+
import membershipsFacundo from '../mocks/memberships.facundo@split.io.json';
66
import { DEBUG } from '@splitsoftware/splitio-commons/src/utils/constants';
77
import { url } from '../testUtils';
88

@@ -23,7 +23,7 @@ export default function (fetchMock, assert) {
2323
// Mocking this specific route to make sure we only get the items we want to test from the handlers.
2424
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
2525
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
26-
fetchMock.get(url(settings, '/mySegments/facundo%40split.io'), { status: 200, body: mySegmentsFacundo });
26+
fetchMock.get(url(settings, '/memberships/facundo%40split.io'), { status: 200, body: membershipsFacundo });
2727

2828
const splitio = SplitFactory({
2929
core: {

src/__tests__/browserSuites/impressions.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { SplitFactory } from '../../';
22
import { settingsFactory } from '../../settings';
33
import splitChangesMock1 from '../mocks/splitchanges.since.-1.json';
44
import splitChangesMock2 from '../mocks/splitchanges.since.1457552620999.json';
5-
import mySegmentsFacundo from '../mocks/mysegments.facundo@split.io.json';
5+
import membershipsFacundo from '../mocks/memberships.facundo@split.io.json';
66
import { OPTIMIZED } from '@splitsoftware/splitio-commons/src/utils/constants';
77
import { truncateTimeFrame } from '@splitsoftware/splitio-commons/src/utils/time';
88
import { url } from '../testUtils';
@@ -26,7 +26,7 @@ export default function (fetchMock, assert) {
2626
// Mocking this specific route to make sure we only get the items we want to test from the handlers.
2727
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=-1'), { status: 200, body: splitChangesMock1 });
2828
fetchMock.get(url(settings, '/splitChanges?s=1.2&since=1457552620999'), { status: 200, body: splitChangesMock2 });
29-
fetchMock.get(url(settings, '/mySegments/facundo%40split.io'), { status: 200, body: mySegmentsFacundo });
29+
fetchMock.get(url(settings, '/memberships/facundo%40split.io'), { status: 200, body: membershipsFacundo });
3030

3131
const splitio = SplitFactory({
3232
core: {

src/__tests__/browserSuites/push-corner-cases.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ const MILLIS_SPLIT_CHANGES_RESPONSE = 400;
3636

3737
/**
3838
* Sequence of calls:
39-
* 0.0 secs: initial SyncAll (/splitChanges, /mySegments/*), auth, SSE connection, SDK_READY_FROM_CACHE
40-
* 0.1 secs: SSE connection opened -> syncAll (/splitChanges, /mySegments/*)
39+
* 0.0 secs: initial SyncAll (/splitChanges, /memberships/*), auth, SSE connection, SDK_READY_FROM_CACHE
40+
* 0.1 secs: SSE connection opened -> syncAll (/splitChanges, /memberships/*)
4141
* 0.2 secs: SPLIT_KILL event -> /splitChanges
4242
* 0.4 secs: /splitChanges response --> SDK_READY
4343
*/
@@ -71,8 +71,8 @@ export function testSplitKillOnReadyFromCache(fetchMock, assert) {
7171

7272
// 1 auth request
7373
fetchMock.getOnce(url(settings, `/v2/auth?s=1.2&users=${encodeURIComponent(userKey)}`), { status: 200, body: authPushEnabledNicolas });
74-
// 2 mySegments requests: initial sync and after SSE opened
75-
fetchMock.get({ url: url(settings, '/mySegments/nicolas%40split.io'), repeat: 2 }, { status: 200, body: { mySegments: [] } });
74+
// 2 memberships requests: initial sync and after SSE opened
75+
fetchMock.get({ url: url(settings, '/memberships/nicolas%40split.io'), repeat: 2 }, { status: 200, body: { ms: {} } });
7676

7777
// 2 splitChanges request: initial sync and after SSE opened. Sync after SPLIT_KILL is not performed because SplitsSyncTask is "executing"
7878
fetchMock.getOnce(url(settings, '/splitChanges?s=1.2&since=25'), { status: 200, body: splitChangesMock1 }, { delay: MILLIS_SPLIT_CHANGES_RESPONSE, /* delay response */ });

0 commit comments

Comments
 (0)