Merge storage-commons into segment-commons

Collapses an unnecessary module layer by moving all RuleBasedSegment
concerns (DTO, domain model, parser, cache interfaces, in-memory impl)
directly into segment-commons, which was the sole consumer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

AI-Session-Id: a0fded26-6434-4263-90b0-a163e1cf0faf
AI-Tool: claude-code
AI-Model: unknown

Author: gthea

client/pom.xml

@@ -177,11 +177,6 @@
             <artifactId>parsing-commons</artifactId>
             <version>${project.version}</version>
         </dependency>
-        <dependency>
-            <groupId>io.split.client</groupId>
-            <artifactId>storage-commons</artifactId>
-            <version>${project.version}</version>
-        </dependency>
         <dependency>
             <groupId>io.split.client</groupId>
             <artifactId>segment-commons</artifactId>

pom.xml

@@ -66,7 +66,6 @@
     <modules>
         <module>targeting-engine</module>
         <module>parsing-commons</module>
-        <module>storage-commons</module>
         <module>segment-commons</module>
         <module>pluggable-storage</module>
         <module>redis-wrapper</module>

segment-commons/pom.xml

@@ -18,7 +18,7 @@
     <dependencies>
         <dependency>
             <groupId>io.split.client</groupId>
-            <artifactId>storage-commons</artifactId>
+            <artifactId>parsing-commons</artifactId>
             <version>${project.version}</version>
         </dependency>
         <dependency>