fix: crashes when trying to close a repository with a action that is still running (#2289)

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/Models/RepositoryUIStates.cs

@@ -246,11 +246,10 @@ public static RepositoryUIStates Load(string gitDir)
             return states;
         }
 
-        public void Unload(string lastCommitMessage)
+        public void Unload()
         {
             try
             {
-                LastCommitMessage = lastCommitMessage;
                 using var stream = File.Create(_file);
                 JsonSerializer.Serialize(stream, this, JsonCodeGen.Default.RepositoryUIStates);
             }

src/ViewModels/Launcher.cs

@@ -230,7 +230,7 @@ public void CloseTab(LauncherPage page)
                     _activeWorkspace.Repositories.Clear();
                     _activeWorkspace.ActiveIdx = 0;
 
-                    repo.Close();
+                    repo.Close(last.Popup is { InProgress: true });
 
                     Welcome.Instance.ClearSearchFilter();
                     last.Node = new RepositoryNode() { Id = Guid.NewGuid().ToString() };
@@ -434,7 +434,7 @@ private void CloseRepositoryInTab(LauncherPage page, bool removeFromWorkspace =
                 if (removeFromWorkspace)
                     _activeWorkspace.Repositories.Remove(repo.FullPath);
 
-                repo.Close();
+                repo.Close(page.Popup is { InProgress: true });
             }
 
             page.Popup?.Cleanup();

src/ViewModels/Repository.cs

@@ -481,12 +481,13 @@ public void Open()
             RefreshAll();
         }
 
-        public void Close()
+        public void Close(bool hasRunningAction)
         {
             SelectedView = null; // Do NOT modify. Used to remove exists widgets for GC.Collect
             Logs.Clear();
 
-            _uiStates.Unload(_workingCopy.CommitMessage);
+            _uiStates.LastCommitMessage = _workingCopy.CommitMessage;
+            _uiStates.Unload();
 
             if (_cancellationRefreshBranches is { IsCancellationRequested: false })
                 _cancellationRefreshBranches.Cancel();
@@ -502,6 +503,9 @@ public void Close()
             _autoFetchTimer.Dispose();
             _autoFetchTimer = null;
 
+            if (hasRunningAction)
+                return;
+
             _settings = null;
             _uiStates = null;
             _historyFilterMode = Models.FilterMode.None;