Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.
This repository was archived by the owner on May 7, 2026. It is now read-only.

LightCycleAppCompatActivity swallows onOptionsItemSelected #53

Description

@xrigau

If you create an activity which extends LightCycleAppCompatActivity and it contains a fragment which extends LightCycleSupportFragment, the activity receives a callback to onOptionsItemSelected when you select an option item (as usual), but the fragment doesn't.

It seems like this might be due to LightCycleAppCompatActivity not calling super.onOptionsItemSelected() - therefore the event doesn't get propagated to the fragments in the activity.

See: https://github.com/soundcloud/lightcycle/blob/master/lightcycle-lib/src/main/java/com/soundcloud/lightcycle/LightCycleAppCompatActivity.java#L47

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions