Skip to content

Commit e4e9d99

Browse files
committed
Loosen webdrivers constraint in solidus_dev_support
Goal ---- As a solidus_starter_frontend user I would like solidus_dev_support to support webdrivers 5.0 So that when solidus_starter_frontend is installed, it won't have to revert the gem to an older version in order to support solidus_dev_support. Expected criteria ----------------- Given I have I installed a Solidus app following the instructions from https://github.com/nebulab/solidus_starter_frontend#for-a-new-store When I check the `Gemfile.lock` file of the app Then I should see that webdrivers has been set to 5.0.0. When I try to install solidus_starter_frontend on top of the Solidus app (https://github.com/nebulab/solidus_starter_frontend#frontend-installation) Then I should see that it is installed successfully Bug description --------------- When the solidus_starter_frontend script tries to install rspec, it encounters the following error: ``` $ LOCATION="https://raw.githubusercontent.com/nebulab/solidus_starter_frontend/master/template.rb" bin/rails app:template ... generate rspec:install rails generate rspec:install Bundler could not find compatible versions for gem "webdrivers": In snapshot (Gemfile.lock): webdrivers (= 5.0.0) In Gemfile: webdrivers solidus_dev_support (~> 2.5) was resolved to 2.5.1, which depends on webdrivers (~> 4.4) Running `bundle update` will rebuild your snapshot from scratch, using only the gems in your Gemfile, which may resolve the conflict. ``` Related ------- See [Loosen puma and rspec-rails version constraints in solidus_dev_support](48cb7ab) for a similar issue. You can also find the commit in #178.
1 parent 372e962 commit e4e9d99

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

solidus_dev_support.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Gem::Specification.new do |spec|
4646
spec.add_dependency 'rubocop-rails', '~> 2.3'
4747
spec.add_dependency 'rubocop-rspec', '~> 2.0'
4848
spec.add_dependency 'solidus_core', ['>= 2.0', '< 4']
49-
spec.add_dependency 'webdrivers', '~> 4.4'
49+
spec.add_dependency 'webdrivers', '>= 4.4'
5050

5151
spec.add_development_dependency 'bundler'
5252
spec.add_development_dependency 'rake'

0 commit comments

Comments
 (0)