Merge pull request #162 from solidusio/elia/factory_bot_fixes

Factory bot fixes for latest Solidus 2.11 release

Author: mergify[bot]

Gemfile

@@ -15,7 +15,6 @@ gem 'rails', '>0.a'
 
 # These gems will be used by the temporary extensions generated by tests
 group :test do
-  gem 'factory_bot', '> 4.10.0'
   gem 'mysql2'
   gem 'pg'
   gem 'solidus_auth_devise'

lib/solidus_dev_support/rspec/rails_helper.rb

@@ -20,10 +20,9 @@
 require 'spree/testing_support/url_helpers'
 require 'spree/testing_support/preferences'
 require 'spree/testing_support/controller_requests'
+require 'solidus_dev_support/testing_support/factories'
 require 'solidus_dev_support/testing_support/preferences'
 
-FactoryBot.find_definitions
-
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
 

lib/solidus_dev_support/templates/extension/spec/spec_helper.rb.tt

@@ -19,7 +19,7 @@ require 'solidus_dev_support/rspec/feature_helper'
 Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
 # Requires factories defined in lib/<%= file_name %>/testing_support/factories.rb
-require '<%= file_name %>/testing_support/factories'
+SolidusDevSupport::TestingSupport::Factories.load_for(<%= class_name %>::Engine)
 
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!

lib/solidus_dev_support/testing_support/factories.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'spree/testing_support/factories'
+require 'factory_bot'
+
+module SolidusDevSupport
+  module TestingSupport
+    module Factories
+      def self.load_for(*engines)
+        paths = engines.flat_map do |engine|
+          engine.root.glob('lib/**/factories.rb')
+        end
+
+        if Spree::TestingSupport.respond_to? :load_all_factories
+          FactoryBot.definition_file_paths.concat(
+            paths.map { |path| path.sub(/.rb\z/, '').to_s }
+          )
+          FactoryBot.reload
+        else
+          FactoryBot.find_definitions
+
+          paths.each { |path| require path }
+        end
+      end
+    end
+  end
+end

solidus_dev_support.gemspec

@@ -32,7 +32,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'capybara-screenshot', '~> 1.0'
   spec.add_dependency 'codecov', '~> 0.2'
   spec.add_dependency 'database_cleaner', '~> 1.7'
-  spec.add_dependency 'factory_bot_rails', '~> 5.1'
+  spec.add_dependency 'factory_bot', '~> 4.8'
+  spec.add_dependency 'factory_bot_rails'
   spec.add_dependency 'ffaker', '~> 2.13'
   spec.add_dependency 'gem-release', '~> 2.1'
   spec.add_dependency 'github_changelog_generator', '~> 1.15'

spec/features/create_extension_spec.rb

@@ -122,11 +122,16 @@ def check_default_task
   end
 
   def check_run_specs
+    install_path.join('lib', 'solidus_test_extension', 'testing_support', 'factories.rb').open('a') do |factories_file|
+      factories_file.write "\n puts 'loading test_extension factories'"
+    end
+
     install_path.join('spec', 'some_spec.rb').write(
       "require 'spec_helper'\nRSpec.describe 'Some test' do it { expect(true).to be_truthy } end\n"
     )
     cd(install_path) do
       output = sh('bundle exec rspec')
+      expect(output).to include('loading test_extension factories')
       expect(output).to include('1 example, 0 failures')
       expect(output).to include(ENV['CODECOV_TOKEN'] ? 'Coverage reports upload successfully' : 'Provide a CODECOV_TOKEN environment variable to enable Codecov uploads')
     end