Skip to content

Commit a30e98a

Browse files
authored
Merge pull request #204 from solidusio/waiting-for-dev/solidus_main
Adapt to latest Solidus release
2 parents dd40b83 + 14a0ba8 commit a30e98a

7 files changed

Lines changed: 21 additions & 16 deletions

File tree

.circleci/config.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ commands:
2020
bundle --version
2121
2222
jobs:
23-
solidus-master:
23+
solidus-main:
2424
executor:
2525
name: solidusio_extensions/sqlite
2626
ruby_version: '3.1'
27-
steps: ['setup', 'solidusio_extensions/run-tests-solidus-master']
27+
steps: ['setup', 'solidusio_extensions/run-tests-solidus-main']
2828
solidus-current:
2929
executor:
3030
name: solidusio_extensions/sqlite
@@ -44,20 +44,20 @@ jobs:
4444
workflows:
4545
"Run specs on supported Solidus versions":
4646
jobs:
47-
- solidus-master
47+
- solidus-main
4848
- solidus-current
4949
- solidus-older
5050
- lint-code
5151

52-
"Weekly run specs against master":
52+
"Weekly run specs against main":
5353
triggers:
5454
- schedule:
5555
cron: "0 0 * * 4" # every Thursday
5656
filters:
5757
branches:
5858
only:
59-
- master
59+
- main
6060
jobs:
61-
- solidus-master
61+
- solidus-main
6262
- solidus-current
6363
- solidus-older

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
77
# Specify your gem's dependencies in solidus_dev_support.gemspec
88
gemspec
99

10-
branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
10+
branch = ENV.fetch('SOLIDUS_BRANCH', 'main')
1111
gem 'solidus', github: 'solidusio/solidus', branch: branch
1212

1313
# A workaround for https://github.com/bundler/bundler/issues/6677

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ the `DB` and `SOLIDUS_BRANCH` env variables.
7878
DB=[postgres|mysql|sqlite] SOLIDUS_BRANCH=<BRANCH-NAME> bin/sandbox
7979
```
8080

81-
By default we use sqlite3 and the master branch.
81+
By default we use sqlite3 and the main branch.
8282

8383
### Rails generators
8484

lib/solidus_dev_support/templates/extension/.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ workflows:
3939
- run-specs-with-mysql
4040
- lint-code
4141

42-
"Weekly run specs against master":
42+
"Weekly run specs against main":
4343
triggers:
4444
- schedule:
4545
cron: "0 0 * * 4" # every Thursday
4646
filters:
4747
branches:
4848
only:
49-
- master
49+
- main
5050
jobs:
5151
- run-specs-with-sqlite
5252
- run-specs-with-postgres

lib/solidus_dev_support/templates/extension/Gemfile.tt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
source 'https://rubygems.org'
44
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
55

6-
branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
6+
branch = ENV.fetch('SOLIDUS_BRANCH', 'main')
77
gem 'solidus', github: 'solidusio/solidus', branch: branch
88

99
# The solidus_frontend gem has been pulled out since v3.2
10-
gem 'solidus_frontend', github: 'solidusio/solidus_frontend' if branch == 'master'
11-
gem 'solidus_frontend' if branch >= 'v3.2' # rubocop:disable Bundler/DuplicatedGem
10+
if branch >= 'v3.2'
11+
gem 'solidus_frontend'
12+
elsif branch == 'main'
13+
gem 'solidus_frontend', github: 'solidusio/solidus_frontend'
14+
else
15+
gem 'solidus_frontend', github: 'solidusio/solidus', branch: branch
16+
end
1217

1318
# Needed to help Bundler figure out how to resolve dependencies,
1419
# otherwise it takes forever to resolve them.

lib/solidus_dev_support/templates/extension/bin/sandbox.tt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ test "$DB" = "sqlite" && export DB="sqlite3"
77

88
if [ -z "$SOLIDUS_BRANCH" ]
99
then
10-
echo "~~> Use 'export SOLIDUS_BRANCH=[master|v3.2|...]' to control the Solidus branch"
11-
SOLIDUS_BRANCH="master"
10+
echo "~~> Use 'export SOLIDUS_BRANCH=[main|v3.2|...]' to control the Solidus branch"
11+
SOLIDUS_BRANCH="main"
1212
fi
1313
echo "~~> Using branch $SOLIDUS_BRANCH of solidus"
1414

lib/solidus_dev_support/templates/extension/extension.gemspec.tt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
2929
spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
3030
spec.require_paths = ["lib"]
3131

32-
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 4']
32+
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 5']
3333
spec.add_dependency 'solidus_support', '~> 0.5'
3434

3535
spec.add_development_dependency 'solidus_dev_support', '<%= SolidusDevSupport.gem_version.approximate_recommendation %>'

0 commit comments

Comments
 (0)