Commit 5cb86c8
committed
Remove Slack notifications for CI failures
We were storing the Slack secrets on a CircleCI context [1]. Although we
were also passing them to forks [2], it resulted on unauthorized builds
for external contributions.
We could work around the issue in two ways:
- Having the secrets outside of any context, but that would compromise
the security of the associated Slack channel for:
- Send messages as @circleci notifications
- Send messages to channels @circleci notifications isn't a member of
- Upload, edit, and delete files as CircleCI notifications
- Using CircleCI logic statements [3] to conditionally run jobs when
`CIRCLECI_USERNAME` or `CIRCLE_PR_USERNAME` env vars [4] are in a list
of allowed users. However, that would be something difficult to
maintain, and there's no other way to check the user's role.
Given that we don't find those trade-offs to be acceptable, we remove
the integration for now.
[1] - https://circleci.com/docs/contexts/
[2] - https://circleci.com/docs/oss/#pass-secrets-to-builds-from-forked-pull-requests
[3] - https://circleci.com/docs/configuration-reference/#logic-statements
[4] - https://circleci.com/docs/variables/1 parent 55b738c commit 5cb86c8
1 file changed
Lines changed: 11 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 22 | | |
31 | 23 | | |
32 | 24 | | |
33 | 25 | | |
34 | 26 | | |
35 | | - | |
| 27 | + | |
36 | 28 | | |
37 | 29 | | |
38 | 30 | | |
39 | 31 | | |
40 | | - | |
| 32 | + | |
41 | 33 | | |
42 | 34 | | |
43 | 35 | | |
44 | 36 | | |
45 | | - | |
| 37 | + | |
46 | 38 | | |
47 | 39 | | |
48 | | - | |
| 40 | + | |
49 | 41 | | |
50 | 42 | | |
51 | 43 | | |
52 | 44 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
61 | 49 | | |
62 | 50 | | |
63 | 51 | | |
| |||
68 | 56 | | |
69 | 57 | | |
70 | 58 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
0 commit comments