Skip to content

Commit 4ed229b

Browse files
authored
Merge pull request #189 from solidusio/elia/rubygems-update
Fix updating rubygems in the CI
2 parents 07737e3 + a5f15d2 commit 4ed229b

3 files changed

Lines changed: 10 additions & 9 deletions

File tree

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ commands:
1414
- run:
1515
name: "Update bundler"
1616
command: |
17-
gem update --system
17+
sudo gem update --system
1818
gem --version
1919
gem install bundler -v '>=2.3.21' --conservative
2020
bundle --version

lib/solidus_dev_support/rspec/feature_helper.rb

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
require 'solidus_dev_support/rspec/rails_helper'
1111
require 'solidus_dev_support/rspec/capybara'
1212

13-
def dev_support_assets_preload
13+
dev_support_assets_preload = ->(*) {
1414
if Rails.application.respond_to?(:precompiled_assets)
1515
Rails.application.precompiled_assets
1616
else
@@ -19,18 +19,14 @@ def dev_support_assets_preload
1919
Rails.application.assets.find_asset(asset)
2020
end
2121
end
22-
end
22+
}
2323

2424
RSpec.configure do |config|
2525
config.when_first_matching_example_defined(type: :feature) do
26-
config.before :suite do
27-
dev_support_assets_preload
28-
end
26+
config.before :suite, &dev_support_assets_preload
2927
end
3028

3129
config.when_first_matching_example_defined(type: :system) do
32-
config.before :suite do
33-
dev_support_assets_preload
34-
end
30+
config.before :suite, &dev_support_assets_preload
3531
end
3632
end

lib/solidus_dev_support/templates/extension/Gemfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ else
2727
gem 'sqlite3'
2828
end
2929

30+
# While we still support Ruby < 3 we need to workaround a limitation in
31+
# the 'async' gem that relies on the latest ruby, since RubyGems doesn't
32+
# resolve gems based on the required ruby version.
33+
gem 'async', '< 3' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3')
34+
3035
gemspec
3136

3237
# Use a local Gemfile to include development dependencies that might not be

0 commit comments

Comments
 (0)